Pooled Array Wrapper - #1167
Open
RuffledPlume wants to merge 11 commits into
Open
Conversation
RuffledPlume
force-pushed
the
PooledArrayChanges
branch
3 times, most recently
from
August 11, 2026 23:38
27d3823 to
1b69f4a
Compare
Instead of `PooledArrayType` returning a raw array, it instead returns a wrapper to help track & manage arrays Added Borrow Contexts to help track leaks
RuffledPlume
force-pushed
the
PooledArrayChanges
branch
from
August 11, 2026 23:39
1b69f4a to
176a608
Compare
RuffledPlume
marked this pull request as ready for review
August 11, 2026 23:39
* Refactor SceneUploader to use `PooledArrayRef` instead of `PooledObjectArray`
RuffledPlume
force-pushed
the
PooledArrayChanges
branch
from
August 14, 2026 03:50
94ebab6 to
9851f1d
Compare
Contributor
Author
|
@aHooder Thoughts on including this into the release? I think I'd prefer if it we're, even if it means delaying the release a little bit, just because this makes the PooledArray API significantly more robust, since where no longer returning raw arrays but wrapped/tracked objects. This PR should make it safer and easier to debug if any issues occur in Prod, since before we could only check for double release by looping through the queue, whereas now it's built into the wrapper along with additional debugging info: |
RuffledPlume
force-pushed
the
PooledArrayChanges
branch
9 times, most recently
from
August 19, 2026 03:37
af9954a to
033179e
Compare
Switch from AtomicLong to AtomicAdder TreiberStack now Extends AtomicReference to avoid the additional object Tweaks
RuffledPlume
force-pushed
the
PooledArrayChanges
branch
from
August 19, 2026 04:31
033179e to
5a26b55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of
PooledArrayTypereturning a raw array, it instead returns a wrapper to help track & manage arraysAdded Borrow Contexts to help track leaks via
CleanerAPI so that if a PooledArray is garbage collected whist still borrowed, which could lead to erroneous behavior since the Object has been revived after GC