Added Highlight command for Models missing overrides - #1157
Conversation
cc7e66c to
1596e94
Compare
aHooder
left a comment
aHooder
left a comment
There was a problem hiding this comment.
LGTM, just a couple small things.
| | (modelOverride.invertDisplacementStrength ? 1 : 0) << 8 | ||
| | (modelOverride.terrainVertexSnap ? 1 : 0) << 6 | ||
| | (modelOverride.terrainVertexSnap ? 1 : 0) << 7 | ||
| | (modelOverride == ModelOverride.NONE && !isActor ? 1 : 0) << 6 |
There was a problem hiding this comment.
Can you create a special material for this instead, similar to how the UNLIT material works? That would in theory simplify stripping it out when the feature is disabled, even though we don't currently do anything like that for materials.
There was a problem hiding this comment.
Wouldn't that mean we need to rebuild all the zones when the feature is active? Since the Static Models which have no override would need to switch over to the HIGHLIGHT material, I think
There was a problem hiding this comment.
Moving it to a HIGHLIGHT Material means this can happen on models without vertex colors:
There was a problem hiding this comment.
Hmm, I see. Kind of hard to say whether it should highlight a case like this though, since it's technically vanilla textured & we tend to replace those by replacing the vanilla texture directly. Maybe we should just skip the highlighting for vanilla textured faces? Might need @Jin-Jiyunsun's input here 👀
333a9b5 to
333a6ff
Compare
7bf910b to
6edddcf
Compare
2 participants
Does what is says on the tin, Command:
::117hd highlightModelOverride.Highlighting.mp4