fix(logging): unified formatter with timestamp, source location, per-request client addr#6
Merged
Merged
Conversation
…per-request client addr Replace basicConfig with dictConfig-based configure_logging(); wire uvicorn and app root to a shared standard formatter (timestamp + level + name + file:lineno). Add RequestLoggingMiddleware that emits one line per request showing client host:port, method, path, status, and duration_ms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unified logging configuration resolving uvicorn default formatter limitations (missing timestamps and source location). Implements dictConfig-based logging with RequestLoggingMiddleware.
Root Cause
Uvicorn's default formatter produced logs without timestamps or file:lineno source location, making debugging and log aggregation difficult.
Solution
log_config.py: dictConfig-based logging factory with shared formatter (timestamp, level, logger name, file:lineno)middleware.py: RequestLoggingMiddleware emits per-request summary (client host:port, method, path, status, duration_ms)main.py: Wire configure_logging() and add middleware to app stackExample Logs
QA Status
✓ APPROVED — 19/19 tests pass, 6/6 QA criteria confirmed