Skip to content

前端业务模块拆分评审(Refs #41 · 仅评审不合并)#42

Open
huyanxius wants to merge 2 commits into
1024XEngineer:mainfrom
huyanxius:docs/41-frontend-module-breakdown
Open

前端业务模块拆分评审(Refs #41 · 仅评审不合并)#42
huyanxius wants to merge 2 commits into
1024XEngineer:mainfrom
huyanxius:docs/41-frontend-module-breakdown

Conversation

@huyanxius

Copy link
Copy Markdown
Collaborator

改动说明

新增 docs/frontend-module-breakdown.md:Windup「一次运行工作流」的前端业务模块拆分,承接产品策划案 #37,是 #39 系统模块拆分的前端对侧。纯文档,不涉及代码改动。

实现方式

按前端页面 / 交互模块拆为 9 块(A 应用基座、B 工作流、C 项目与角色资产、D 生成、E 审核、F 手感模拟质检、G 导出、H 账户、I 积分计费),每块列出行为与所需后端请求。术语对齐架构 #3 与导师评审口径:基准帧 / 动作模板 / 动作 / 造型。

测试

Not run(纯文档、无代码改动;本 PR 仅用于逐行评审、不合并)。


Refs #41 · 仅评审不合并,评审定稿后内容落回 #41

MS2 has a system-side module split (1024XEngineer#39) but no front-end counterpart, while the product proposal (1024XEngineer#37) is finalized and ready to decompose.

Add docs/frontend-module-breakdown.md splitting the single workflow run into nine front-end modules, each listing UI behaviors and the backend requests it needs.

Terminology follows architecture 1024XEngineer#3 and mentor review: base frame, action template and action, and the outfit layer. Review-only, not merged.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review found three documentation inconsistencies that should be resolved before using this breakdown as an implementation contract. See the inline findings for the affected scope and request inventories.

Comment thread docs/frontend-module-breakdown.md Outdated
从项目开始 ───┘ 项目 → 角色/造型基准帧 → 动作 → 生成 → 审核 → 网页手感模拟质检 → 导出
```

所有模块都挂在一次运行工作流上。画布展示节点、连线、当前步骤和运行状态。

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This says every module is attached to one workflow run, but the document later defines Account (H) and Credits & Billing (I) as separate modules and explicitly excludes both from MS2. Please narrow this statement to the workflow modules (B–G), or clarify how these cross-cutting modules relate to a run so the architecture scope is not contradictory.

@huyanxius huyanxius Jul 21, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — that line overstated it. Narrowed it: a workflow run is composed of the C–G step nodes orchestrated by B, while app base (A), account (H), and billing (I) are cross-cutting and not part of any single run. Fixed in 7bce913.

Comment thread docs/frontend-module-breakdown.md Outdated
需要请求:

- 获取项目列表和详情
- 创建和修改项目名称

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI requirements in C1 include editing the theme, art style, reference images, view mode, direction count, and canvas size (lines 74–75), but the request inventory only includes creating/editing the project name. Please list the create/update operations for those project constraints, or remove them from the promised UI scope.

@huyanxius huyanxius Jul 21, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed — the C1 request list did not cover the project constraints exposed in the UI. Added: create project (name, theme, art style, reference image, view mode, direction count, canvas size) and update project constraints. Fixed in 7bce913.


- 获取角色列表和详情
- 创建角色
- 获取和确认造型基准帧

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C2 requires uploading a reference image, saving the character name/identity description, and submitting a base-frame generation request, but this request list only covers listing/creating characters and getting/confirming base frames. Please add the missing character update/upload and generation-initiation requests so the module has a complete backend contract.

@huyanxius huyanxius Jul 21, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — two parts here. The reference-image upload / character update was indeed missing; the create and update character requests now carry the fields (name, character identity description, reference image). For generation initiation: C2 only submits the generation request, while the actual initiation lives in module D (see D1 "start generation, base frame vs. action"), so it is a cross-module reference and is not duplicated here. Fixed in 7bce913.

fennoai flagged three inconsistencies where the module scope and per-module request lists did not match the UI above them.

Narrow the "single workflow run" statement to the C–G step nodes orchestrated by B, and mark app base, account, and billing as cross-cutting. Expand the project request list to cover all project constraints, and add character create/update payload requests.

Generation initiation stays in module D as before, so no request is added for it here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant