Skip to content

fix(docs): Not yet Supports files up to 4GB#271

Open
cyfung1031 wants to merge 2 commits into
101arrowz:masterfrom
cyfung1031:fix/doc/no-Supports-files-up-to-4GB
Open

fix(docs): Not yet Supports files up to 4GB#271
cyfung1031 wants to merge 2 commits into
101arrowz:masterfrom
cyfung1031:fix/doc/no-Supports-files-up-to-4GB

Conversation

@cyfung1031

Copy link
Copy Markdown

README claimed that "Supports files up to 4GB", but this is factually incorrect because zip64 support has not yet been implemented - see #230

@101arrowz

Copy link
Copy Markdown
Owner

This bullet point refers to GZIP/Zlib/DEFLATE, not ZIP. Pako doesn't support ZIP at all, so this update currently makes it look like fflate has worse support for 4GB files than Pako, while in reality, the level of support is identical. I'd rather remove the bullet point entirely until ZIP64 support is merged, but I do intend to do so for the next release, so this would probably not be gone for too long anyway.

Feel free to switch this to removing the bullet point, otherwise I'll close and the docs will be correct with the next update.

@cyfung1031

Copy link
Copy Markdown
Author

I'd rather remove the bullet point entirely until ZIP64 support is merged

Feel free to switch this to removing the bullet point

OK switched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants