Repository navigation
fix: Share one lock when defining scopes - #356
Merged
Merged
Conversation
Each define_scope call created its own lock, so checking whether a scope was already defined and binding it wasn't atomic across threads: two threads could define the same shared scope, the second overwriting the first. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Every caller now passes an existing lock, so the function no longer creates one: it returns the given lock when threadsafe, otherwise a null context. InjectMetadata receives its lock explicitly. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The scope definition lock is renamed to __thread_lock and only protects the binding of scopes; slot writes use a lock of their own again. lock_if_threadsafe now creates a lock only when none is given and the call is threadsafe. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
No user code runs while the scope locks are held, so they never need to be reacquired by the same thread. The module lock stays reentrant, since recipes can resolve dependencies while it is held. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.