Repository navigation
fix: Share one lock per module for threadsafe resolution - #353
Merged
Merged
Conversation
get_lock created a new lock on each call, so find_instance and afind_instance never excluded each other, and each @Inject function had its own lock. A singleton could be created several times despite threadsafe=True. get_lock can now reuse an existing lock, and each module passes its own. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
threading.RLock is a function before Python 3.13, so evaluating `RLock | None` at import time raised a TypeError. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.