add remaining admin functions for duration vault management - #543
Merged
Conversation
evercoinx
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Adds new DEFAULT_ADMIN_ROLE-gated controls that can change delegation approval, rewards-claim authorization, and forcibly advance vault state to withdrawals, which are sensitive operational actions. Logic is straightforward (address checks + forwarding), but misuse or incorrect role assignment could impact vault access and reward flows.
Overview
Adds three new
EigenAdapteradmin-callable operations for EigenLayer duration vault management:updateDelegationApprover,setRewardsClaimer, andadvanceToWithdrawals, each performing a zero-address guard, forwarding the call to the vault, and emitting new interface events.Extends
IEigenAdapterwith the corresponding function declarations and events, updates the duration-vault mock, and adds/updates unit tests to cover success cases, idempotency, and role/zero-address reverts. Minor script/test files are also re-formatted for readability with no behavioral change.Reviewed by Cursor Bugbot for commit e4378f3. Bugbot is set up for automated code reviews on this repo. Configure here.