CYS3-02: Upgradeable Storage Layout Changes Can Corrupt Live Proxies - #542
Merged
Conversation
dB2510
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Adds a new regression test that will fail on any storage layout drift in upgradeable contracts; runtime/protocol behavior is unchanged, but CI may start failing if layouts change without updating the baseline.
Overview
Adds
StorageLayout.t.sol, a Foundry unit test that reads each contract’sout/<Contract>.jsonstorageLayoutoutput and asserts a pinned baseline (label/slot/offset/type) for core UUPS proxies (StakeManager,RewardsManager,SlashingManager,SSPRouter,OraclePriceFeed,SymbioticAdapter,EigenAdapter).Includes helper logic to normalize solc/Foundry type identifiers by stripping build-dependent AST node IDs before comparison, so the test only fails on real storage layout changes.
Reviewed by Cursor Bugbot for commit 48357ad. Bugbot is set up for automated code reviews on this repo. Configure here.