fix: implement CYS3-02 fix - #540
Closed
evercoinx wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
High Risk
High risk because it changes storage layouts for multiple UUPS-upgradeable core contracts and introduces on-chain migration steps; any layout mismatch or missed migration could brick proxies or corrupt committee/operator state.
Overview
This PR hardens upgrade safety across the UUPS suite by preserving storage layout compatibility:
RoleActivationTimelockis moved to ERC-7201 namespaced storage, multiple contracts add explicit__gapslots, and several removed/renamed state variables are retained as_deprecated_*placeholders (e.g., inRewardsManager,SSPRouter,SlashingManager,StakeManager).It also adds post-upgrade migration tooling for
StakeManager: new admin-only, idempotent functionsbackfillCommitteeIds()andmigrateOperatorCommittees()plus aMigrateOperatorCommittees.s.solscript, and updatesUpgradeAllContracts.s.soldocs to require manual storage-layout verification and running the migration after upgrading.Reviewed by Cursor Bugbot for commit 6919320. Bugbot is set up for automated code reviews on this repo. Configure here.