Repository navigation
feat: add --filter flag to forge run with dependency resolution, validation, tests, and docs - #75
Merged
Conversation
- Add --filter flag to forge run for stage (<stage>) and step (<stage>.<step>) filtering - Automatically resolve and include stage dependencies (DAG) - Validate filter targets and produce user-friendly errors with available options - Add comprehensive unit and integration test coverage - Update README and usage documentation Closes 0xReLogic#69, Closes 0xReLogic#70, Closes 0xReLogic#71, Closes 0xReLogic#72, Closes 0xReLogic#73
Owner
|
Thank you for the excellent contribution! The implementation is clean and well aligned. The dependency resolution, filter validation, test coverage, and documentation are all thoughtfully done. Great work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
--filterflag toforge run, allowing developers to run a specific stage or an individual step within a stage without executing the entire pipeline.Highlights
--filter <stage>and--filter <stage>.<step>toforge run(conflicts_with = "stage").depends_on), executing prerequisites before running the target stage/step (matching Issue feat: --filter should automatically include stage dependencies #73).ExitCode::ConfigError) (matching Issue feat: validate --filter input and produce user-friendly errors #70).src/config/mod.rsand end-to-end integration tests intests/integration_tests.rs(matching Issue test: add unit tests for stage and step filter resolution #71).README.mdanddocs/usage.mdwith usage examples and descriptions (matching Issue docs: document --filter flag in README and usage guide #72).Verification
cargo fmt --check: Passed cleanlycargo clippy -- -D warnings: Passed with 0 warningscargo test: All 76 tests passed (including existing suites and 8 new tests)Closes #69, Closes #70, Closes #71, Closes #72, Closes #73