Repository navigation
Conversation
… steps Replace sequential await loop in collect_parallel_results with futures_util::future::select_all so that a failing task aborts all siblings immediately, regardless of task order in the handle list. The previous implementation awaited handles one-by-one, meaning a slow task at index 0 would block detection of a fast failure at index N. Also adds: - Test for slow-first / fast-fail-last concurrent scenario - Test for empty handle input edge case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the follow-up concern raised in #58 the
collect_parallel_resultsfunction was awaiting task handles sequentially, meaning a slow task at index 0 would block detection of a fast failure at index N.Changes
for handle in handlesloop withfutures_util::future::select_allfor true concurrent monitoringTests
All unit tests pass:
Closes the improvement suggested in #58.