refactor(core)!: simplify tool and hook APIs#2133
Closed
gold-silver-copper wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tool::call(&mut ToolContext, args)path and one structuredToolExecutionErrorenvelopeDynamicTool, collapse tool/result metadata intoToolContext, and expose one structured dispatch method onToolSetandToolServerHandleFlow/StepEventhook dispatch with event-specific lifecycle methods and action types, preserving patch merging, rewrite chaining, nested stacks, and run/stream parityValidation
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-featurescargo check --workspace --all-targets --all-featurescargo check -p rig-core --no-default-features --features wasm,rmcp --target wasm32-unknown-unknowncargo test -p rig-core --all-features agent::(275 passed, 2 ignored)cargo test -p rig-core --all-features tool::(43 passed)cargo test -p rig-derive --all-featurescargo doc -p rig-core --no-depsis blocked by a Rust 1.94.0stringdexsearch-index ICE. A fullrig-corerun also has one unchanged Gemini image-generation baseline failure; all 1,228 other tests passed (8 ignored), and focused changed-surface suites are green.Addresses #2126