Scope the crate with an include list - #8
Merged
Merged
Conversation
Replace the exclude denylist with an include allowlist naming exactly what ships. Cargo ignores exclude once include is set and include does not consult .gitignore, so examples are listed file by file. A CI job plants untracked files and fails unless every file in the crate is tracked source or cargo metadata. Agent working directories are ignored.
0xFantomMenace
force-pushed
the
fix/package-scope
branch
from
September 23, 2026 02:33
7e73529 to
14596c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crate used an
excludedenylist, so any new file in the directory would ship by default.This change replaces it with an
includeallowlist. Cargo ignoresexcludeonceincludeis set, andincludedoes not consult.gitignore, so examples are named file by file: a directory pattern would also pick up untracked local files. APackage contentsCI job plants untracked files at the root, insrc/and inexamples/, and fails unless every file in the crate is tracked source or metadata cargo generates. Agent working directories are ignored.Test plan
cargo package --listwith untracked files planted lists only tracked sources,Cargo.lock,Cargo.toml.origand.cargo_vcs_info.json