Scope the sdist to the package - #8
Open
0xFantomMenace wants to merge 2 commits into
Open
0xFantomMenace wants to merge 2 commits into
0xFantomMenace wants to merge 2 commits into
Conversation
The wheel has always been scoped to the oxarchive package, but the sdist had no scope at all, so the build backend included every non-ignored file in the working directory. Version 1.8.0's sdist is 1.67 MB against an 87 KB wheel because of it. List what ships instead of relying on the default, and ignore agent working directories so they cannot be swept in again. A rebuilt sdist is 84 KB and 30 files.
The include list fixes today's build. This stops it regressing: the job plants a stray directory, builds the sdist, and fails if anything outside the package ends up inside it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wheel has always been scoped to the
oxarchivepackage. The sdist had no scope at all, so the build backend included every non-ignored file in the working directory at build time.The effect is visible on the published artifacts for 1.8.0: the wheel is 87 KB and the sdist is 1.67 MB.
This adds an explicit
[tool.hatch.build.targets.sdist]include list, so the source distribution carries the package, the readme, the changelog, the licence and the project file, and nothing else. It also ignores agent working directories so they cannot be picked up by a future build.Verified by rebuilding: the sdist goes from 1.67 MB and 654 files to 84 KB and 30 files.