Repository navigation
Conversation
Declare --ui-grid-table-row-height on .ui-grid-table so check:tokens treats var() reads in the same file as a file-local custom property. Co-authored-by: froQ <sayhola@froq.me>
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pnpm checkfails atcheck:tokenson commits throughf483e20:GridTablesets--ui-grid-table-row-heightinline anddisplay.cssreads it withvar(), but the token checker only allows reads of the 12 contract tokens intokens.cssunless the same file declares the custom property.Fix
Add a default on
.ui-grid-table:This matches the component default; inline styles from
GridTable.vuecan still override it.Verification
pnpm install --frozen-lockfile && pnpm check(includingcheck:tokens)Note
The same one-line fix was pushed directly to
mainas81ec46bwhile this branch was prepared. This PR documents the minimal change for review; do not merge ifmainalready contains it—close when satisfied.