Extract Endpoint#params: introduce DSL::Param and DSL::SetParam classes

Author: sineed

lib/rspec_api_documentation/dsl/endpoint.rb

@@ -1,6 +1,7 @@
 require 'rspec/core/formatters/base_formatter'
 require 'rack/utils'
 require 'rack/test/utils'
+require 'rspec_api_documentation/dsl/endpoint/params'
 
 module RspecApiDocumentation::DSL
   # DSL methods available inside the RSpec example.
@@ -63,11 +64,7 @@ def query_string
     end
 
     def params
-      parameters = example.metadata.fetch(:parameters, {}).inject({}) do |hash, param|
-        set_param(hash, param)
-      end
-      parameters.deep_merge!(extra_params)
-      parameters
+      Params.new(self, example: example, extra_params: extra_params).call
     end
 
     def header(name, value)
@@ -99,14 +96,6 @@ def status
       rspec_api_documentation_client.status
     end
 
-    def in_path?(param)
-      path_params.include?(param)
-    end
-
-    def path_params
-      example.metadata[:route].scan(/:(\w+)/).flatten
-    end
-
     def path
       example.metadata[:route].gsub(/:(\w+)/) do |match|
         if extra_params.keys.include?($1)
@@ -146,34 +135,5 @@ def delete_extra_param(key)
       @extra_params.delete(key.to_sym) || @extra_params.delete(key.to_s)
     end
 
-    def set_param(hash, param)
-      key                = param[:name]
-      key_scope          = param[:scope] && Array(param[:scope]).dup.push(key)
-      scoped_key         = key_scope && key_scope.join('_')
-      custom_method_name = param[:method]
-      path_name          = scoped_key || key
-
-      return hash if in_path?(path_name)
-
-      build_param_data = if custom_method_name && respond_to?(custom_method_name)
-        [key_scope || [key], custom_method_name]
-      elsif scoped_key && respond_to?(scoped_key)
-        [key_scope, scoped_key]
-      elsif respond_to?(key)
-        [key_scope || [key], key]
-      else
-        []
-      end
-      # binding.pry if key == "street"
-
-      return hash if build_param_data.empty?
-      hash.deep_merge(build_param_hash(*build_param_data))
-    end
-
-    def build_param_hash(keys, method_name)
-      value = keys[1] ? build_param_hash(keys[1..-1], method_name) : send(method_name)
-      { keys[0].to_s => value }
-    end
-
   end
 end

lib/rspec_api_documentation/dsl/endpoint/params.rb

@@ -0,0 +1,30 @@
+require 'rspec_api_documentation/dsl/endpoint/set_param'
+
+module RspecApiDocumentation
+  module DSL
+    module Endpoint
+      class Params
+        attr_reader :example_group, :example
+
+        def initialize(example_group, example:, extra_params:)
+          @example_group = example_group
+          @example = example
+          @extra_params = extra_params
+        end
+
+        def call
+          parameters = example.metadata.fetch(:parameters, {}).inject({}) do |hash, param|
+            SetParam.new(self, hash: hash, param: param).call
+          end
+          parameters.deep_merge!(extra_params)
+          parameters
+        end
+
+      private
+
+        attr_reader :extra_params
+
+      end
+    end
+  end
+end

lib/rspec_api_documentation/dsl/endpoint/set_param.rb

@@ -0,0 +1,62 @@
+module RspecApiDocumentation
+  module DSL
+    module Endpoint
+      class SetParam
+        def initialize(parent, hash:, param:)
+          @parent = parent
+          @hash = hash
+          @param = param
+        end
+
+        def call
+          return hash if path_params.include?(path_name)
+          return hash unless method_name
+
+          hash.deep_merge build_param_hash(key_scope || [key])
+        end
+
+      private
+
+        attr_reader :parent, :hash, :param
+        delegate :example_group, :example, to: :parent
+
+        def key
+          @key ||= param[:name]
+        end
+
+        def key_scope
+          @key_scope ||= param[:scope] && Array(param[:scope]).dup.push(key)
+        end
+
+        def scoped_key
+          @scoped_key ||= key_scope && key_scope.join('_')
+        end
+
+        def custom_method_name
+          param[:method]
+        end
+
+        def path_name
+          scoped_key || key
+        end
+
+        def path_params
+          example.metadata[:route].scan(/:(\w+)/).flatten
+        end
+
+        def method_name
+          @method_name ||= begin
+            [custom_method_name, scoped_key, key].find do |name|
+              name && example_group.respond_to?(name)
+            end
+          end
+        end
+
+        def build_param_hash(keys)
+          value = keys[1] ? build_param_hash(keys[1..-1]) : example_group.send(method_name)
+          { keys[0].to_s => value }
+        end
+      end
+    end
+  end
+end