Skip to content

Commit c0c969a

Browse files
authored
Run safety checker always in make safety (#2086)
Signed-off-by: Andreas Maier <maiera@de.ibm.com>
1 parent af8386d commit c0c969a

1 file changed

Lines changed: 4 additions & 16 deletions

File tree

Makefile

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ help:
290290
@echo " check - Run Flake8 on sources"
291291
@echo " ruff - Run Ruff (an alternate lint tool) on sources"
292292
@echo " pylint - Run PyLint on sources"
293-
@echo " safety - Run safety for install and all"
293+
@echo " safety - Run safety checker"
294294
@echo " bandit - Run bandit checker"
295295
@echo " unittest - Run unit tests (adds to coverage results)"
296296
@echo " functiontest - Run function tests (adds to coverage results)"
@@ -466,7 +466,9 @@ pylint: $(done_dir)/pylint_$(pymn)_$(PACKAGE_LEVEL).done
466466
@echo "Makefile: $@ done."
467467

468468
.PHONY: safety
469-
safety: $(done_dir)/safety_develop_$(pymn)_$(PACKAGE_LEVEL).done $(done_dir)/safety_install_$(pymn)_$(PACKAGE_LEVEL).done
469+
safety: Makefile $(done_dir)/develop_$(pymn)_$(PACKAGE_LEVEL).done $(safety_develop_policy_file) $(safety_install_policy_file) minimum-constraints-develop.txt minimum-constraints-install.txt
470+
bash -c "safety check --policy-file $(safety_develop_policy_file) -r minimum-constraints-develop.txt --full-report || test '$(RUN_TYPE)' == 'normal' || test '$(RUN_TYPE)' == 'scheduled' || exit 1"
471+
bash -c "safety check --policy-file $(safety_install_policy_file) -r minimum-constraints-install.txt --full-report || test '$(RUN_TYPE)' == 'normal' || exit 1"
470472
@echo "Makefile: $@ done."
471473

472474
.PHONY: bandit
@@ -632,20 +634,6 @@ $(done_dir)/pylint_$(pymn)_$(PACKAGE_LEVEL).done: Makefile $(done_dir)/develop_$
632634
echo "done" >$@
633635
@echo "Makefile: Done running Pylint"
634636

635-
$(done_dir)/safety_develop_$(pymn)_$(PACKAGE_LEVEL).done: Makefile $(done_dir)/develop_$(pymn)_$(PACKAGE_LEVEL).done $(safety_develop_policy_file) minimum-constraints-develop.txt minimum-constraints-install.txt
636-
@echo "Makefile: Running Safety for development packages (and tolerate safety issues when RUN_TYPE is normal or scheduled)"
637-
-$(call RM_FUNC,$@)
638-
bash -c "safety check --policy-file $(safety_develop_policy_file) -r minimum-constraints-develop.txt --full-report || test '$(RUN_TYPE)' == 'normal' || test '$(RUN_TYPE)' == 'scheduled' || exit 1"
639-
echo "done" >$@
640-
@echo "Makefile: Done running Safety for development packages"
641-
642-
$(done_dir)/safety_install_$(pymn)_$(PACKAGE_LEVEL).done: Makefile $(done_dir)/develop_$(pymn)_$(PACKAGE_LEVEL).done $(safety_install_policy_file) minimum-constraints-install.txt
643-
@echo "Makefile: Running Safety for install packages (and tolerate safety issues when RUN_TYPE is normal)"
644-
-$(call RM_FUNC,$@)
645-
bash -c "safety check --policy-file $(safety_install_policy_file) -r minimum-constraints-install.txt --full-report || test '$(RUN_TYPE)' == 'normal' || exit 1"
646-
echo "done" >$@
647-
@echo "Makefile: Done running Safety for install packages"
648-
649637
$(done_dir)/bandit_$(pymn)_$(PACKAGE_LEVEL).done: Makefile $(done_dir)/develop_$(pymn)_$(PACKAGE_LEVEL).done $(bandit_rc_file) $(check_py_files)
650638
@echo "Makefile: Running Bandit"
651639
-$(call RM_FUNC,$@)

0 commit comments

Comments
 (0)