CI: Fix Meson mixup between Conda and system Python headers#839
Merged
Conversation
DimitriPapadopoulos
force-pushed
the
fix-cython
branch
from
ae1fe57 to
ba76b14
Compare
DimitriPapadopoulos
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #839 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 901 901
=========================================
Hits 901 901 🚀 New features to boost your workflow:
|
DimitriPapadopoulos
force-pushed
the
fix-cython
branch
4 times, most recently
from
2260335 to
64ebfea
Compare
DimitriPapadopoulos
force-pushed
the
fix-cython
branch
18 times, most recently
from
995f2ab to
bc238da
Compare
Otherwise, Meson insists on getting Cython to include system Python headers which simply doesn't work: ----- Sanity check compile stderr: In file included from /usr/include/python3.10/Python.h:8, from sanity_check_for_cython.c:19: /usr/include/python3.10/pyconfig.h:9:12: fatal error: aarch64-linux-gnu/python3.10/pyconfig.h: No such file or directory 9 | # include <aarch64-linux-gnu/python3.10/pyconfig.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. ----- Also, avoid starting a new shell!
DimitriPapadopoulos
force-pushed
the
fix-cython
branch
from
bc238da to
dc6cd1a
Compare
DimitriPapadopoulos
changed the title
Contributor
Author
|
Perhaps it's time to drop Conda... C/C++ compilers are readily available in GitHub runners. Why reinstall C/C++ compilers with Conda? |
Conda was used to get GCC or Clang for compiling the C extensions. GitHub Actions runners come with C/C++ compilers pre-installed.
DimitriPapadopoulos
changed the title
DimitriPapadopoulos
changed the title
Contributor
Author
|
@d-v-b Could you have a look at the latest change, which solves the mixup between Conda and system-wide Python headers by removing Conda altogether? |
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CI failure. Convince Meson to pick Python headers installed by Conda, not system-wide headers.This really feels like a hack. I don't know enough about meson to understand and fix this mess cleanly. There has to be a way though, Meson cannot be that broken. Any clues?Edit: A better strategy is probably to remove Conda altogether, used primarily to install C/C++ compilers, as C/C++ compilers are readily available in GitHub runners.
TODO: