From 091417e2b6c7539cbdcf99ad5bfd63143d9105e2 Mon Sep 17 00:00:00 2001 From: Sal <59910950+ss-o@users.noreply.github.com> Date: Sat, 19 Sep 2026 05:51:40 +0100 Subject: [PATCH] fix(skills): zi-install supports ZI_HOME overrides only with -i skip The -a loader block does not propagate ZI_HOME or ZI_BIN_DIR_NAME, so the first shell start would clone a second Zi at the default location (z-shell/src#217). Restrict the overrides to install-only until the installer carries them. Refs #636 --- .github/skills/zi-install/SKILL.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/skills/zi-install/SKILL.md b/.github/skills/zi-install/SKILL.md index 8265a8807..7a913bc3c 100644 --- a/.github/skills/zi-install/SKILL.md +++ b/.github/skills/zi-install/SKILL.md @@ -23,6 +23,7 @@ Prefer Loader for a new setup. Use `-i skip` when the user manages their dotfile - `.zshrc` lives in `${ZDOTDIR:-$HOME}`; report that path before running. `ZDOTDIR` and `ZI_HOME`, when set, must be absolute: the installer changes directory before it reads them, so a relative value targets the wrong place. Stop and ask the user if either is relative. - The installer honours `XDG_CONFIG_HOME` and `XDG_DATA_HOME` only when they are absolute; a relative value falls back to `~/.config` and `~/.local/share`. Say which directories will be used. - An existing installation is detected by the installer (`~/.zi` or `$XDG_DATA_HOME/zi`, or an explicit `ZI_HOME`). Do not move or delete it. +- An explicit `ZI_HOME` or `ZI_BIN_DIR_NAME` is supported only with `-i skip`. The Loader block does not carry them, so with `-a loader` the first shell start would clone a second Zi at the default location (z-shell/src#217). If the user has either set and wants Loader, stop and explain that. - `zsh`, `git`, and `curl` or `wget` must be present; the installer refuses without `git`. ## Run the installer