fix: tweak jest setting and code style

Author: Gerald Yeo

README.md

@@ -4,6 +4,7 @@
 
 [![npm][npm-badge]][npm-link]
 [![Build Status][circle-badge]][circle-link]
+[![Coverage Status][codecov-badge]][codecov-link]
 [![PRs Welcome][pr-welcome-badge]][pr-welcome-link]
 
 This webpack plugin allows you to filter the list of output files before
@@ -107,3 +108,5 @@ For more info, check out the [usage.spec.js](./src/usage.spec.js) for more info.
 [multimatch-package]: https://github.com/sindresorhus/multimatch
 [pr-welcome-badge]: https://img.shields.io/badge/PRs-welcome-brightgreen.svg?style=flat-square
 [pr-welcome-link]: https://github.com/yeojz/filter-chunk-webpack-plugin/blob/master/CONTRIBUTING.md
+[codecov-badge]: https://img.shields.io/codecov/c/github/yeojz/filter-chunk-webpack-plugin/master.svg?style=flat-square
+[codecov-link]: https://codecov.io/gh/yeojz/filter-chunk-webpack-plugin

package-lock.json

@@ -29,7 +29,6 @@
     "url": "https://github.com/yeojz/filter-chunk-webpack-plugin/issues"
   },
   "devDependencies": {
-    "ajv": "^5.5.2",
     "babel-cli": "^6.26.0",
     "babel-preset-env": "^1.6.1",
     "codecov": "^3.0.0",
@@ -53,6 +52,7 @@
       "<rootDir>/index.js"
     ],
     "resetMocks": true,
+    "testEnvironment": "node",
     "testPathIgnorePatterns": [
       "/node_modules/",
       "/dist/",

package.json

@@ -1,31 +1,29 @@
 import FilterChunkWebpackPlugin from './index';
 
-describe('FilterChunkWebpackPlugin', function() {
-  const PATTERN_ERROR = 'The "patterns" option should be an array';
+const PATTERN_ERROR = 'The "patterns" option should be an array';
 
-  it('should set options from constructor', function() {
-    const plugin = new FilterChunkWebpackPlugin({
-      select: true,
-      patterns: ['**/**']
-    });
-
-    expect(plugin.options.select).toBe(true);
-    expect(plugin.options.patterns).toEqual(['**/**']);
+test('should set options from constructor', () => {
+  const plugin = new FilterChunkWebpackPlugin({
+    select: true,
+    patterns: ['**/**']
   });
 
-  it('should set defaults from constructor', function() {
-    const plugin = new FilterChunkWebpackPlugin();
+  expect(plugin.options.select).toBe(true);
+  expect(plugin.options.patterns).toEqual(['**/**']);
+});
 
-    expect(plugin.options.select).toEqual(false);
-    expect(plugin.options.patterns).toEqual([]);
-  });
+test('should set defaults from constructor', () => {
+  const plugin = new FilterChunkWebpackPlugin();
 
-  it('should throw an Error when patterns is not array', function() {
-    const plugin = () =>
-      new FilterChunkWebpackPlugin({
-        patterns: 'test'
-      });
+  expect(plugin.options.select).toEqual(false);
+  expect(plugin.options.patterns).toEqual([]);
+});
 
-    expect(plugin).toThrow(PATTERN_ERROR);
-  });
+test('should throw an Error when patterns is not array', () => {
+  const plugin = () =>
+    new FilterChunkWebpackPlugin({
+      patterns: 'test'
+    });
+
+  expect(plugin).toThrow(PATTERN_ERROR);
 });

src/index.spec.js

@@ -6,56 +6,63 @@ import FilterChunkWebpackPlugin from './index';
 const OUTPUT_ROOT = path.join(path.resolve(__dirname), '..', '.spec_output');
 const INPUT_ROOT = path.join(path.resolve(__dirname), '..', 'fixtures');
 
-describe('Webpack with FilterChunkWebpackPlugin', function() {
-  it('[1] should not modify assets by default', function(done) {
-    const config = generateWebpackConfiguration('it-1');
+jest.setTimeout(10000);
 
-    webpack(config, function(err, stats) {
-      const assets = Object.keys(stats.compilation.assets);
+test('[1] should not modify assets by default', done => {
+  const config = generateWebpackConfiguration('it-1');
 
-      expect(err).toBeFalsy();
-      expect(stats.compilation.warnings.length).toEqual(0);
-      expect(assets).toHaveLength(4);
+  const compiler = webpack(config);
 
-      done();
-    });
+  compiler.run((err, stats) => {
+    const assets = Object.keys(stats.compilation.assets);
+
+    expect(err).toBeFalsy();
+    expect(stats.hasErrors()).toBeFalsy();
+    expect(stats.hasWarnings()).toBeFalsy();
+    expect(assets).toHaveLength(4);
+
+    done();
   });
+});
 
-  it('[2] should omit all relevant matches', function(done) {
-    const config = generateWebpackConfiguration('it-2', {
-      patterns: ['assets/**', '!assets/css/**']
-    });
+test('[2] should omit all relevant matches', done => {
+  const config = generateWebpackConfiguration('it-2', {
+    patterns: ['assets/**', '!assets/css/**']
+  });
 
-    webpack(config, function(err, stats) {
-      const assets = Object.keys(stats.compilation.assets);
+  const compiler = webpack(config);
+  compiler.run((err, stats) => {
+    const assets = Object.keys(stats.compilation.assets);
 
-      expect(err).toBeFalsy();
-      expect(stats.compilation.warnings.length).toEqual(0);
-      expect(assets).toHaveLength(2);
-      expect(assets).toContain('app.js');
-      expect(assets).toContain('assets/css/app.css');
+    expect(err).toBeFalsy();
+    expect(stats.hasErrors()).toBeFalsy();
+    expect(stats.hasWarnings()).toBeFalsy();
+    expect(assets).toHaveLength(2);
+    expect(assets).toContain('app.js');
+    expect(assets).toContain('assets/css/app.css');
 
-      done();
-    });
+    done();
   });
+});
 
-  it('[3] should pick all relevant matches', function(done) {
-    const config = generateWebpackConfiguration('it-3', {
-      select: true,
-      patterns: ['assets/**', '!assets/css/**']
-    });
+test('[3] should pick all relevant matches', done => {
+  const config = generateWebpackConfiguration('it-3', {
+    select: true,
+    patterns: ['assets/**', '!assets/css/**']
+  });
 
-    webpack(config, function(err, stats) {
-      const assets = Object.keys(stats.compilation.assets);
+  const compiler = webpack(config);
+  compiler.run((err, stats) => {
+    const assets = Object.keys(stats.compilation.assets);
 
-      expect(err).toBeFalsy();
-      expect(stats.compilation.warnings.length).toEqual(0);
-      expect(assets).toHaveLength(2);
-      expect(assets).toContain('assets/images/png.png');
-      expect(assets).toContain('assets/images/svg.svg');
+    expect(err).toBeFalsy();
+    expect(stats.hasErrors()).toBeFalsy();
+    expect(stats.hasWarnings()).toBeFalsy();
+    expect(assets).toHaveLength(2);
+    expect(assets).toContain('assets/images/png.png');
+    expect(assets).toContain('assets/images/svg.svg');
 
-      done();
-    });
+    done();
   });
 });