Follow-up from PR #273 (build hooks)
The per-file transform build hook added in #273 is covered by:
- unit tests (including the eager disk-read fallback path), and
- an e2e test that exercises the traditional packaging pipeline.
It is not covered by an e2e test in the SEA pipeline. The SEA path is structurally covered (sea-assets prefers record.body, which transform writes), but there is no end-to-end test proving a transform hook actually applies when building a SEA binary.
Why deferred
A SEA e2e is heavyweight and host-Node-version dependent, so it was left out of the review-fix scope rather than block the PR.
Scope
- Add an e2e test that builds a SEA binary for a fixture with a
transform hook configured, and asserts the transformed bytes land in the produced executable.
- Keep it consistent with the existing e2e harness conventions.
Follow-up from #273.
Follow-up from PR #273 (build hooks)
The per-file
transformbuild hook added in #273 is covered by:It is not covered by an e2e test in the SEA pipeline. The SEA path is structurally covered (sea-assets prefers
record.body, whichtransformwrites), but there is no end-to-end test proving atransformhook actually applies when building a SEA binary.Why deferred
A SEA e2e is heavyweight and host-Node-version dependent, so it was left out of the review-fix scope rather than block the PR.
Scope
transformhook configured, and asserts the transformed bytes land in the produced executable.Follow-up from #273.