Skip to content

Web profiler has no way to tune --min-share/--intersection-floor/--imbalance-flag/--missing-flag/--min-group-size - only the CLI does #284

Description

@yakew7

faircode/cli.py lets faircode profile/compare tune five detection thresholds via --min-share, --intersection-floor, --imbalance-flag, --missing-flag, and --min-group-size, each documented in faircode/SPEC.md §7 and mirrored one-for-one in assets/profiler-engine.js's DEFAULT_OPTS (which accepts min_share/intersection_floor/imbalance_flag/missing_flag/min_group_size as overridable options).

But assets/profiler-ui.js only ever wires up cross and reference into currentOpts - confirmed no DOM element for any of the five thresholds exists anywhere in profiler.html, and no getElementById call for any of them exists in profiler-ui.js. Every browser-side profile run is permanently locked to the hardcoded defaults, so a web-profiler user auditing a dataset at a different scale (e.g. wanting --min-group-size 20 for a small sample) has no way to do it without switching to the CLI, even though the engine underneath already supports it.

Proposed scope: add input controls (e.g. a collapsible 'advanced thresholds' panel) to profiler.html for the five thresholds, and wire them into currentOpts in assets/profiler-ui.js the same way cross/reference already are - matching faircode/SPEC.md §7's documented defaults.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is needed

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions