Add proper phpstan types for arrays

Author: xPaw

Examples/View.php

@@ -16,7 +16,7 @@
 
 	$Query = new SourceQuery( );
 
-	$Info    = [];
+	$Info    = null;
 	$Rules   = [];
 	$Players = [];
 	$Exception = null;
@@ -105,7 +105,7 @@
 						</tr>
 					</thead>
 					<tbody>
-<?php if( !empty( $Info ) ): ?>
+<?php if( $Info !== null ): ?>
 <?php foreach( $Info as $InfoKey => $InfoValue ): ?>
 						<tr>
 							<td><?php echo htmlspecialchars( $InfoKey ); ?></td>
@@ -128,7 +128,7 @@
 		}
 		else
 		{
-			echo htmlspecialchars( $InfoValue );
+			echo htmlspecialchars( (string)$InfoValue );
 		}
 	}
 ?></td>
@@ -152,7 +152,7 @@
 						</tr>
 					</thead>
 					<tbody>
-<?php if( !empty( $Players ) ): ?>
+<?php if( count( $Players ) > 0 ): ?>
 <?php foreach( $Players as $Player ): ?>
 						<tr>
 							<td><?php echo htmlspecialchars( $Player[ 'Name' ] ); ?></td>
@@ -178,7 +178,7 @@
 						</tr>
 					</thead>
 					<tbody>
-<?php if( !empty( $Rules ) ): ?>
+<?php if( count( $Rules ) > 0 ): ?>
 <?php foreach( $Rules as $Rule => $Value ): ?>
 						<tr>
 							<td><?php echo htmlspecialchars( $Rule ); ?></td>

SourceQuery/Buffer.php

@@ -50,6 +50,8 @@ public function Set( string $Buffer ) : void
 	 * Get remaining bytes
 	 *
 	 * @return int Remaining bytes in buffer
+	 *
+	 * @phpstan-impure
 	 */
 	public function Remaining( ) : int
 	{

SourceQuery/SourceQuery.php

@@ -185,7 +185,42 @@ public function Ping( ) : bool
 	 * @throws InvalidPacketException
 	 * @throws SocketException
 	 *
-	 * @return array Returns an array with information on success
+	 * @return array{
+	 *     Protocol: int,
+	 *     HostName: string,
+	 *     Map: string,
+	 *     ModDir: string,
+	 *     ModDesc: string,
+	 *     AppID?: int,
+	 *     Players: int,
+	 *     MaxPlayers: int,
+	 *     Bots: int,
+	 *     Dedicated: string,
+	 *     Os: string,
+	 *     Password: bool,
+	 *     Secure: bool,
+	 *     Version?: string,
+	 *     ExtraDataFlags?: int,
+	 *     GamePort?: int,
+	 *     SteamID?: string|int,
+	 *     SpecPort?: int,
+	 *     SpecName?: string,
+	 *     GameTags?: string,
+	 *     GameID?: int,
+	 *     Address?: string,
+	 *     IsMod?: bool,
+	 *     Mod?: array{
+	 *         Url: string,
+	 *         Download: string,
+	 *         Version: int,
+	 *         Size: int,
+	 *         ServerSide: bool,
+	 *         CustomDLL: bool
+	 *     },
+	 *     GameMode?: int,
+	 *     WitnessCount?: int,
+	 *     WitnessTime?: int
+	 * } Returns an array with server information on success
 	 */
 	public function GetInfo( ) : array
 	{
@@ -364,7 +399,7 @@ public function GetInfo( ) : array
 	 * @throws InvalidPacketException
 	 * @throws SocketException
 	 *
-	 * @return array Returns an array with players on success
+	 * @return array<int, array{Id: int, Name: string, Frags: int, Time: int, TimeF: string}> Returns an array with players on success
 	 */
 	public function GetPlayers( ) : array
 	{
@@ -409,7 +444,7 @@ public function GetPlayers( ) : array
 	 * @throws InvalidPacketException
 	 * @throws SocketException
 	 *
-	 * @return array Returns an array with rules on success
+	 * @return array<string, string> Returns an array with rules on success
 	 */
 	public function GetRules( ) : array
 	{
@@ -438,7 +473,7 @@ public function GetRules( ) : array
 			$Rule  = $Buffer->ReadNullTermString( );
 			$Value = $Buffer->ReadNullTermString( );
 
-			if( !empty( $Rule ) )
+			if( strlen( $Rule ) > 0 )
 			{
 				$Rules[ $Rule ] = $Value;
 			}

phpstan.neon

@@ -7,16 +7,12 @@ parameters:
 		- .
 	excludePaths:
 		- vendor
-		- Examples/View.php
 	strictRules:
 		booleansInConditions: false
 	ignoreErrors:
 		- identifier: missingType.iterableValue
-		- identifier: empty.notAllowed
+		  path: Tests/Tests.php
 		- identifier: cast.int
+		  path: SourceQuery/Buffer.php
 		- identifier: cast.double
-
-		-
-			message: "#^Comparison operation \"\\>\" between int\\<1, max\\> and 0 is always true\\.$#"
-			count: 1
-			path: SourceQuery/SourceQuery.php
+		  path: SourceQuery/Buffer.php