Skip to content

Commit 8fc9971

Browse files
committed
fix(ci): pin unstable action versions and fix bugs
- Pin sonarsource actions from @master to @v4/@v1 - Update actions/github-script from v6.3.0 to v7 - Remove dead cancel-workflow step in schema-linter (referenced pull_request_target but workflow only triggers on pull_request) - Fix leftover "faustwp" project name in run-docker.sh - Add .nvmrc (Node 18) as single source of truth for Node version Relates to #411
1 parent 047cdfc commit 8fc9971

4 files changed

Lines changed: 5 additions & 8 deletions

File tree

.github/workflows/schema-linter.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,6 @@ jobs:
2727
options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
2828

2929
steps:
30-
- name: Cancel previous runs of this workflow (pull requests only)
31-
if: ${{ github.event_name == 'pull_request_target' }}
32-
uses: styfle/cancel-workflow-action@0.11.0
33-
3430
- name: Checkout
3531
uses: actions/checkout@v4
3632
with:

.github/workflows/sonar.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
steps:
1414
- name: Check if PR author is an org member
1515
id: check-member
16-
uses: actions/github-script@v6.3.0 # Updated version to support Node 20
16+
uses: actions/github-script@v7
1717
with:
1818
script: |
1919
const org = 'wpengine';
@@ -47,13 +47,13 @@ jobs:
4747
fetch-depth: 0
4848

4949
- name: SonarQube Scan
50-
uses: sonarsource/sonarqube-scan-action@master
50+
uses: sonarsource/sonarqube-scan-action@v4
5151
env:
5252
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
5353
SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}
5454

5555
- name: SonarQube Quality Gate check
56-
uses: sonarsource/sonarqube-quality-gate-action@master
56+
uses: sonarsource/sonarqube-quality-gate-action@v1
5757
# Force to fail step after specific time
5858
timeout-minutes: 5
5959
env:

.nvmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
18

bin/run-docker.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ case "$subcommand" in
3939
esac
4040
done
4141
docker build $BUILD_NO_CACHE \
42-
-t faustwp:${TAG}-wp-${WP_VERSION} \
42+
-t wp-graphql-content-blocks:${TAG}-wp-${WP_VERSION} \
4343
--build-arg WP_VERSION=${WP_VERSION} \
4444
./.docker;
4545
;;

0 commit comments

Comments
 (0)