Skip to content

Validate constants provided with --extra-php to avoid PHP notices #148

Description

@ecotechie

The example on the wp config create command's page has an issue. When I create a config like this:

wp config create --dbname=testing --dbuser=wp --dbpass=securepswd --extra-php <<PHP
define( 'WP_DEBUG', true );
define( 'WP_DEBUG_LOG', true );
PHP

It adds the debug true, not seeing that by default debug false is already set. This creates warnings on every consecutive run of wp and also adds these to the log.

When doing wp config set WP_DEBUG true --raw instead, it changes the existing false setting to true, or creates it...

Should we be checking for these constants when adding them with --extra-php?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions