Announcements approval email not sent when created by superuser

[skyflaren]

[JasonLovesDoggo]

Believe this is fixed. @nyiyui confirm?

[nyiyui]

I don't think so... 'll have to confirm though.

By the way: How should it behave, maybe have a "Send Approval Email" checkbox for superusers?

[JasonLovesDoggo]

I don't think so... 'll have to confirm though.

By the way: How should it behave, maybe have a "Send Approval Email" checkbox for superusers?

Why not just have it in admin.save? Isn't that how it's done atm? But we would have to do it via API anyways bc of the new frontend

[nyiyui]

RN, email sending is skipped if the user is superuser (presumably for "fixes"h, etc) I think API v3 one also does the same thing.

…

On Fri, May 19, 2023 at 2:00 PM Jason ***@***.***> wrote: I don't think so... 'll have to confirm though. By the way: How should it behave, maybe have a "Send Approval Email" checkbox for superusers? Why not just have it in admin.save? Isn't that how it's done atm? But we would have to do it via API anyways bc of the new frontend — Reply to this email directly, view it on GitHub <#129 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AK5PL6KD5573FATRVHCDNV3XG6YNLANCNFSM5HN6PHMA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[JasonLovesDoggo]

Partial fix is that there is a "resend approval email" admin action