fix: error when integrity option is enabled but no template defined in entry, #107

Author: webdiscus

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change log
 
+## 3.17.2 (2024-08-08)
+
+- fix: error when `integrity` option is enabled but no template defined in entry, #107
+
 ## 3.17.1 (2024-08-01)
 
 - fix: when using the integrity option, leaves the original attributes in the script tag as is

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "html-bundler-webpack-plugin",
-  "version": "3.17.1",
+  "version": "3.17.2",
   "description": "HTML bundler plugin for webpack handles a template as an entry point, extracts CSS and JS from their sources referenced in HTML, supports template engines like Eta, EJS, Handlebars, Nunjucks.",
   "keywords": [
     "html",

package.json

@@ -299,9 +299,11 @@ class Integrity {
       this.assetHashes.set(compilation, assetHashes);
       const hashes = this.hashes.get(compilation);
 
-      for (const [hash, value] of hashes) {
-        const assetFile = value.next().value;
-        assetHashes.set(assetFile, hash);
+      if (hashes) {
+        for (const [hash, value] of hashes) {
+          const assetFile = value.next().value;
+          assetHashes.set(assetFile, hash);
+        }
       }
     }
 

src/Plugin/Extras/Integrity.js

@@ -0,0 +1 @@
+console.log(">> main");

test/cases/integrity-enabled-wo-template/expected/main.js

@@ -0,0 +1 @@
+console.log('>> main');

test/cases/integrity-enabled-wo-template/src/main.js

@@ -0,0 +1,20 @@
+const path = require('path');
+const HtmlBundlerPlugin = require('@test/html-bundler-webpack-plugin');
+
+module.exports = {
+  mode: 'production',
+
+  output: {
+    path: path.join(__dirname, 'dist/'),
+    crossOriginLoading: 'anonymous', // required for test Subresource Integrity
+  },
+
+  // test enabled integrity option, but no template is defined, see #107
+  entry: './src/main.js', // this file should exist, contents don't matter
+
+  plugins: [
+    new HtmlBundlerPlugin({
+      integrity: true,
+    }),
+  ],
+};

test/cases/integrity-enabled-wo-template/webpack.config.js

@@ -468,8 +468,7 @@ describe('integrity, common use cases', () => {
   test('script, link, publicPath="auto"', () => compareFiles('integrity-publicPath-auto'));
   test('script, link, publicPath=""', () => compareFiles('integrity-publicPath-empty'));
   test('script, link, publicPath="/"', () => compareFiles('integrity-publicPath-root'));
-  
-  
+
   test('script async, prod', () => compareFiles('integrity-script-async-prod'));
 
   test('split chunks', () => compareFiles('integrity-split-chunks'));
@@ -478,6 +477,8 @@ describe('integrity, common use cases', () => {
 
   test('hook-done', () => compareFiles('integrity-hook-done'));
   test('hook-integrityHashes', () => compareFiles('integrity-hook-integrityHashes'));
+
+  test('integrity enabled w/o using template in entry', () => compareFiles('integrity-enabled-wo-template'));
 });
 
 describe('integrity, dynamic chunks', () => {