Fix deaddrop connection stability and UI flash

google-labs-jules[bot] · lws-team · commit f3661e366052 · 2025-08-18T21:38:28.000+01:00
diff --git a/lib/core-net/wsi-timeout.c b/lib/core-net/wsi-timeout.c
@@ -194,7 +194,7 @@ lws_set_timeout_us(struct lws *wsi, enum pending_timeout reason, lws_usec_t us)
 	__lws_sul_insert_us(&pt->pt_sul_owner[LWSSULLI_MISS_IF_SUSPENDED],
 			    &wsi->sul_timeout, us);
 
-	lwsl_wsi_notice(wsi, "%llu us, reason %d",
+	lwsl_wsi_info(wsi, "%llu us, reason %d",
 			     (unsigned long long)us, reason);
 
 	wsi->pending_timeout = (char)reason;
diff --git a/lib/core/context.c b/lib/core/context.c
@@ -1177,8 +1177,8 @@ lws_create_context(const struct lws_context_creation_info *info)
 			context->default_retry.retry_ms_table_count =
 					LWS_ARRAY_SIZE(default_backoff_table);
 	context->default_retry.jitter_percent = 20;
-	context->default_retry.secs_since_valid_ping = 300;
-	context->default_retry.secs_since_valid_hangup = 310;
+	context->default_retry.secs_since_valid_ping = 40;
+	context->default_retry.secs_since_valid_hangup = 50;
 
 	if (info->retry_and_idle_policy &&
 	    info->retry_and_idle_policy->secs_since_valid_ping) {
diff --git a/lib/roles/h2/http2.c b/lib/roles/h2/http2.c
@@ -1983,7 +1983,7 @@ lws_h2_parse_end_of_frame(struct lws *wsi)
 		break;
 
 	case LWS_H2_FRAME_TYPE_GOAWAY:
-		lwsl_notice("GOAWAY: last sid %u, error 0x%08X, string '%s'\n",
+		lwsl_wsi_notice(wsi, "RX GOAWAY: last sid %u, error 0x%08X, string '%s'\n",
 			  (unsigned int)h2n->goaway_last_sid,
 			  (unsigned int)h2n->goaway_err, h2n->goaway_str);
 
diff --git a/lib/roles/ws/ops-ws.c b/lib/roles/ws/ops-ws.c
@@ -2118,18 +2118,24 @@ rops_issue_keepalive_ws(struct lws *wsi, int isvalid)
 						     encapsulation_parent(wsi);
 
 		assert(enc);
+		lwsl_wsi_info(wsi, "trying to do keepalive on h2 wrapper around ws");
 		if (lws_rops_func_fidx(enc->role_ops, LWS_ROPS_issue_keepalive).
-						  issue_keepalive(enc, isvalid))
+						  issue_keepalive(enc, isvalid)) {
+			lwsl_wsi_err(wsi, "FAILED to keep h2 wrapper for ws alive");
 			return 1;
+		}
 	}
 #endif
 
-	if (isvalid)
+	if (isvalid) {
+		lwsl_wsi_info(wsi, "confirming validity");
 		_lws_validity_confirmed_role(wsi);
-	else {
+	} else {
 		us = (uint64_t)lws_now_usecs();
 		memcpy(&wsi->ws->ping_payload_buf[LWS_PRE], &us, 8);
 		wsi->ws->send_check_ping = 1;
+		lwsl_wsi_info(wsi, "requesting send ping on ws");
+
 		lws_callback_on_writable(wsi);
 	}
 
diff --git a/plugins/deaddrop/assets/deaddrop.css b/plugins/deaddrop/assets/deaddrop.css
@@ -66,7 +66,7 @@ table {
 	transition: background-color 0.5s ease;
 }
 table.nb { border: 0px; border-radius: 0px; transition: opacity 0.5s; }
-table.noconn { background-color: #ddd; width: 100%; }
+table.noconn { background-color: #ddd; }
 
 div { transition: opacity 0.5s; }
 div.da { padding-left: 20px; padding-right:20px; }
diff --git a/plugins/deaddrop/assets/index.html b/plugins/deaddrop/assets/index.html
@@ -7,7 +7,7 @@
  <body>
 	 <div class="title"><img src="/docrepo.svg"> Deaddrop</div>
 	<div class="uplbox">
-		<table id="ddrop" class="noconn">
+		<table id="ddrop">
 			<tr>
 				<th>Drag and drop files</th>
 				<th>Paste text to upload:</th>
diff --git a/plugins/deaddrop/protocol_lws_deaddrop.c b/plugins/deaddrop/protocol_lws_deaddrop.c

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ table {`
`66`	`66`	`transition: background-color 0.5s ease;`
`67`	`67`	`}`
`68`	`68`	`table.nb { border: 0px; border-radius: 0px; transition: opacity 0.5s; }`
`69`		`-table.noconn { background-color: #ddd; width: 100%; }`
	`69`	`+table.noconn { background-color: #ddd; }`
`70`	`70`
`71`	`71`	`div { transition: opacity 0.5s; }`
`72`	`72`	`div.da { padding-left: 20px; padding-right:20px; }`