From f6a2971c4da6f398d2cc0395cb4af01f4e9b7afa Mon Sep 17 00:00:00 2001 From: Joe Isaacs Date: Mon, 7 Sep 2026 11:34:07 +0000 Subject: [PATCH] ci(bench): drop Clickbench Sorted from the "pr" SQL benchmark preset The sorted ClickBench variant no longer runs in the default pull-request SQL benchmark matrix (the `action/bench-sql` label). It still runs under `pr-compact`, `pr-all`, `pr-full`, and `develop`. Since `pr-all` is the union of `pr` and `pr-compact`, its coverage for this case narrows to the compact targets. Signed-off-by: Joe Isaacs Co-Authored-By: Claude Fable 5.1 Claude-Session: https://claude.ai/code/session_01C9e8MM2rjbnH4qN4jtzMKm --- bench-orchestrator/bench_orchestrator/ci_matrix/catalog.py | 4 ++-- bench-orchestrator/tests/test_matrix.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bench-orchestrator/bench_orchestrator/ci_matrix/catalog.py b/bench-orchestrator/bench_orchestrator/ci_matrix/catalog.py index 9f8f0fee915..08483980e54 100644 --- a/bench-orchestrator/bench_orchestrator/ci_matrix/catalog.py +++ b/bench-orchestrator/bench_orchestrator/ci_matrix/catalog.py @@ -93,14 +93,14 @@ "develop": FULL_LOCAL, }, ), + # Not in the "pr" preset: the sorted variant is excluded from the default PR benchmark run. BenchmarkCase( id="clickbench-sorted-nvme", benchmark=Benchmark.CLICKBENCH_SORTED, name="Clickbench Sorted on NVME", runs={ - "pr": DEFAULT, "pr-compact": COMPACT, - "pr-all": STANDARD, + "pr-all": COMPACT, "pr-full": DEFAULT_WITH_DUCKDB_PR_FULL, "develop": FULL_LOCAL, }, diff --git a/bench-orchestrator/tests/test_matrix.py b/bench-orchestrator/tests/test_matrix.py index d0f765be246..4b6c270b5c1 100644 --- a/bench-orchestrator/tests/test_matrix.py +++ b/bench-orchestrator/tests/test_matrix.py @@ -42,7 +42,7 @@ "pr": tuple( benchmark_id for benchmark_id in REGULAR_IDS - if benchmark_id not in {"tpch-s3-10", "appian-nvme", "vortex-queries"} + if benchmark_id not in {"clickbench-sorted-nvme", "tpch-s3-10", "appian-nvme", "vortex-queries"} ), "pr-compact": COMPACT_IDS, "pr-all": PR_ALL_IDS,