Export of the pluginForCjs function in the plugin-react-swc package

[asurion-fahad]

In my code I was getting parsing errors from this line of statement export { pluginForCjs as 'module.exports' }. I believe it's due to the way this function is being exported and the fact that I use esnext as my Typescript module. In order to resolve this I had to patch the package in my repo. I was wondering, why is it being exported as 'module.exports'? It seems conflicting since react is exported as default.

[ArnaudBarre]

I think this is for cjs/esm compat.
Do you have the parsing error when running tsc or at runtime?
I think either your node or ts version is under our minimal supported version

[asurion-fahad]

The parsing error occurs when running tsc. I have Node v22 and Typescript 5.8.3. But as I digged more into this I think the issue is with the esnext module, I came across this suggestion when using Claude:
export { react as default, pluginForCjs as "module.exports" };

String literal export names in declaration files are only accepted by TypeScript when module is set to "node16", "nodenext", or "commonjs". With module: "esnext", the parser treats this as a syntax error and skipLibCheck: true does not suppress it because skipLibCheck skips type checking of .d.ts files. 
We worked around it by patching index.d.ts to change the export. Would it be possible to provide a declaration that's compatible with module: "esnext" consumers

The way I patched it is by removing the "module.exports" so the export would look like this: export { react as default, pluginForCjs }; I guess to summarize TypeScript only allows export { x as "string literal" } in a .d.ts file when the module compiler option is set to "node16", "nodenext", or "commonjs". It rejects it when module is "esnext". Hope that helps

[ArnaudBarre]

The actual error is TS18057: String literal import and export names are not supported when the '--module' flag is set to 'es2015' or 'es2020'.
And it disapear with you set "skipLibCheck": true,

You are probably looking at the wrong file

If you either change one (and I recommend changing both), this it should be fixed

[asurion-fahad]

So you're saying that if I have my configurations set something like this, I'll get the TS18057 error.

module: 'es2015' // or 'es2020
skipLibCheck: false

But if I change either one it should fix. That's true I don't get that error but I am getting a different error.

// Below is what I have
module: 'esnext'
skipLibCheck: true

This is the exact error I'm getting

:44 - error TS1003: Identifier expected.

58 export { react as default, pluginForCjs as "module.exports" };
                                              ~~~~~~~~~~~~~~~~

../.yarn/__virtual__/@vitejs-plugin-react-swc-virtual-77c4c1fa9b/0/cache/@vitejs-plugin-react-swc-npm-4.3.0-39d765192d-a4b010ec9f.zip/node_modules/@vitejs/plugin-react-swc/index.d.ts:58:61 - error TS1128: Declaration or statement expected.

58 export { react as default, pluginForCjs as "module.exports" };
                                                               ~


Found 2 errors in the same file, starting at: ../.yarn/__virtual__/@vitejs-plugin-react-swc-virtual-77c4c1fa9b/0/cache/@vitejs-plugin-react-swc-npm-4.3.0-39d765192d-a4b010ec9f.zip/node_modules/@vitejs/plugin-react-swc/index.d.ts:58

[ArnaudBarre]

We have been using these settings in the template for quite a long time and I can't reproduce nor we got other reports

I think the actually used TS version when you run the command is not actually 5.8 and you have an older one installed somewhere in your project

[asurion-fahad]

Yeah you're right, in the app where I got this parsing error my TS version is 5.8.3 but in the root directory it is 5.5.4. Thanks! I'll make the upgrade

[asurion-fahad]

This feature of supporting arbitrary module identifiers was added in 5.6. Upgrading to at least that version fixed the problem. Thanks!