Skip to content

DNS: Name skipping logic can walk arbitrarily far on malformed labels #56

Description

@braindigitalis

Both question-skip and answer-name-skip do:

pos += 1 + response[pos] for normal labels.

There is no check that:

response[pos] is a sane label length (DNS labels must be ≤ 63)
pos + 1 + response[pos] <= len before incrementing

So a single byte like 0xFF can make pos jump well beyond the end. Later code then reads from those positions.

This is another OOB read / crash primitive.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions