Commit ddd84ef
committed
Address review feedback on #161
Three follow-ups from PR review:
1. Revert README badge slugs for PyPI downloads and npm downloads per
@r4ghu. The download counters should continue to reflect the old
`inferedge-moss-core` / `@inferedge/moss` packages until the new
`moss` / `@moss-dev/moss` installs reach critical volume. Keeps the
PyPI version + npm version badges (the top-of-page links) pointing
at the new packages.
2. Revert the MAINTAINERS.md Python doc-source path change. The old
entry pointed at `python/user-facing-sdk/src/inferedge_moss/__init__.pyi`
and my previous edit moved it to `sdks/python/sdk/src/moss/__init__.pyi`,
but Copilot correctly flagged that the regen command
(`python scripts/generate_docs.py`) doesn't exist in the current
repo — neither script nor script dir are present anywhere under
`sdks/`. The whole regen workflow is stale in ways beyond this
rebrand; leaving the path as it was so it's obviously-stale for the
docs team to rewrite properly, rather than half-updated.
3. Regenerate `packages/vitepress-plugin-moss/pnpm-lock.yaml` via
`pnpm install --lockfile-only`. The previous commit renamed the
`@inferedge/moss` dep in package.json but didn't refresh the lock,
so `pnpm install --frozen-lockfile` would have failed in CI (Devin
flag). Lock now cleanly references `@moss-dev/moss` with zero
`@inferedge` entries.
Not addressed (out of scope for this PR):
- `packages/vitepress-plugin-moss/demo-site/package-lock.json` has
2 pre-existing `@inferedge/moss` refs. That file exists on `main`
before this PR, the demo-site is a pnpm workspace (pnpm-lock.yaml
is the active lockfile and is clean), and npm can't even regenerate
it because it uses `link:..` for the workspace dep. Orphan from a
prior npm-era install; leaving for separate cleanup.
- `portal.usemoss.dev` references throughout — intentionally
preserved per the rebrand policy decision.1 parent 7a8eab7 commit ddd84ef
3 files changed
Lines changed: 60 additions & 620 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
0 commit comments