Skip to content

Commit ddd84ef

Browse files
Address review feedback on #161
Three follow-ups from PR review: 1. Revert README badge slugs for PyPI downloads and npm downloads per @r4ghu. The download counters should continue to reflect the old `inferedge-moss-core` / `@inferedge/moss` packages until the new `moss` / `@moss-dev/moss` installs reach critical volume. Keeps the PyPI version + npm version badges (the top-of-page links) pointing at the new packages. 2. Revert the MAINTAINERS.md Python doc-source path change. The old entry pointed at `python/user-facing-sdk/src/inferedge_moss/__init__.pyi` and my previous edit moved it to `sdks/python/sdk/src/moss/__init__.pyi`, but Copilot correctly flagged that the regen command (`python scripts/generate_docs.py`) doesn't exist in the current repo — neither script nor script dir are present anywhere under `sdks/`. The whole regen workflow is stale in ways beyond this rebrand; leaving the path as it was so it's obviously-stale for the docs team to rewrite properly, rather than half-updated. 3. Regenerate `packages/vitepress-plugin-moss/pnpm-lock.yaml` via `pnpm install --lockfile-only`. The previous commit renamed the `@inferedge/moss` dep in package.json but didn't refresh the lock, so `pnpm install --frozen-lockfile` would have failed in CI (Devin flag). Lock now cleanly references `@moss-dev/moss` with zero `@inferedge` entries. Not addressed (out of scope for this PR): - `packages/vitepress-plugin-moss/demo-site/package-lock.json` has 2 pre-existing `@inferedge/moss` refs. That file exists on `main` before this PR, the demo-site is a pnpm workspace (pnpm-lock.yaml is the active lockfile and is clean), and npm can't even regenerate it because it uses `link:..` for the workspace dep. Orphan from a prior npm-era install; leaving for separate cleanup. - `portal.usemoss.dev` references throughout — intentionally preserved per the rebrand policy decision.
1 parent 7a8eab7 commit ddd84ef

3 files changed

Lines changed: 60 additions & 620 deletions

File tree

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010

1111
[![License](https://img.shields.io/badge/License-BSD_2--Clause-orange.svg)](https://opensource.org/licenses/BSD-2-Clause)
1212
[![PyPI](https://img.shields.io/pypi/v/moss?color=deepgreen)](https://pypi.org/project/moss/)
13-
[![PyPI downloads](https://static.pepy.tech/personalized-badge/moss?period=total&units=international_system&left_color=grey&right_color=blue&left_text=pypi+downloads)](https://pepy.tech/project/moss)
13+
[![PyPI downloads](https://static.pepy.tech/personalized-badge/inferedge-moss-core?period=total&units=international_system&left_color=grey&right_color=blue&left_text=pypi+downloads)](https://pepy.tech/project/inferedge-moss-core)
1414
[![npm](https://img.shields.io/npm/v/@moss-dev/moss?color=deepgreen)](https://www.npmjs.com/package/@moss-dev/moss)
15-
[![npm downloads](https://img.shields.io/npm/dt/@moss-dev/moss?label=npm+downloads&color=blue)](https://www.npmjs.com/package/@moss-dev/moss)
15+
[![npm downloads](https://img.shields.io/npm/dt/@inferedge/moss?label=npm+downloads&color=blue)](https://www.npmjs.com/package/@inferedge/moss)
1616
[![Discord](https://img.shields.io/discord/1433962929526542346?logo=discord&logoColor=white&label=Discord&color=7B2FBE)](https://moss.link/discord)
1717

1818
[Website](https://moss.dev) · [Docs](https://docs.moss.dev) · [Discord](https://moss.link/discord) · [Blog](https://moss.dev/blog)

packages/vitepress-plugin-moss/demo-site/documentation/MAINTAINERS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ The following files are completely generated by tooling and should not be edited
99
| Path | Source | Command |
1010
| --- | --- | --- |
1111
| `docs/reference/js/**/*` | `javascript/user-facing-sdk/typedoc.json` | `npm run docs` (inside `javascript/user-facing-sdk/`) |
12-
| `docs/reference/python/**/*` | `sdks/python/sdk/src/moss/__init__.pyi` | `python scripts/generate_docs.py` (inside `sdks/python/sdk/`) |
12+
| `docs/reference/python/**/*` | `python/user-facing-sdk/src/inferedge_moss/__init__.pyi` | `python scripts/generate_docs.py` (inside `python/user-facing-sdk/`) |
1313

1414
When these commands run, the contents of those paths are overwritten. Commit the regenerated files after confirming they build.
1515

0 commit comments

Comments
 (0)