MetadataInterface::getSpace() return type incorrect

[ChrisDBrown]

Trying to get a smaller replication case, but currently seeing a case where Markup/Contentful/DynamicEntry->getSpace() returns Markup/Contentful/Link which is not of type Markup/Contentful/SpaceInterface as expected.

[ChrisDBrown]

https://github.com/usemarkup/contentful/blob/master/src/ResourceBuilder.php#L266
Is getting Link

[ChrisDBrown]

https://github.com/usemarkup/contentful/blob/master/src/ResourceBuilder.php#L52:L60
hmmmmm

[ChrisDBrown]

[shieldo]

Interesting - thanks for the report! I hadn't experienced this previously, but certainly anything requested from an entry should be a resolved resource, not just the link.

[ChrisDBrown]

https://github.com/usemarkup/contentful/blob/master/src/ResourceBuilder.php#L67
My suspicion is that the issue lies here - based on what's returning I'd expect this to be checking for Type == Link && linkType == Space, as I don't see any instances where getType returns Space

[ChrisDBrown]

^ going to put up a PR to this effect for review, as it appears to resolve the issue locally, but I'm not 100% clear on the original intent here.

EDIT: retracting this, as it seemed to cause issues elsewhere. It does seem "more correct" to return the Space here than an unresolved Link, but it seems like fixing this is causing issues further downstream.
https://github.com/usemarkup/contentful/blob/master/src/ResourceBuilder.php#L163
Initial thought was to extend this check to also include type "Space", and copy the above code for space handling.

[ChrisDBrown]

Just to better illustrate the above: #92