diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml index b92a1988..4a60207f 100644 --- a/.github/workflows/python-package.yml +++ b/.github/workflows/python-package.yml @@ -52,7 +52,7 @@ jobs: prefix = "rtichoke/_vendor/rtichoke_viz/" required = { f"{prefix}VENDORED_FROM", - f"{prefix}rtichoke-viz-0.20.0.tar.gz", + f"{prefix}rtichoke-viz-0.20.1.tar.gz", f"{prefix}rtichoke-viz.js", f"{prefix}rtichoke-viz.css", f"{prefix}rtichoke-viz.schema.json", @@ -60,6 +60,7 @@ jobs: f"{prefix}rtichoke-viz-report.schema.json", } assert required <= names + assert f"{prefix}rtichoke-viz-0.20.0.tar.gz" not in names assert f"{prefix}rtichoke-viz-0.19.0.tar.gz" not in names assert f"{prefix}rtichoke-viz-0.14.0.tar.gz" not in names PY diff --git a/src/rtichoke/_vendor/rtichoke_viz/VENDORED_FROM b/src/rtichoke/_vendor/rtichoke_viz/VENDORED_FROM index f2b79588..22383d7d 100644 --- a/src/rtichoke/_vendor/rtichoke_viz/VENDORED_FROM +++ b/src/rtichoke/_vendor/rtichoke_viz/VENDORED_FROM @@ -1,5 +1,5 @@ repository=https://github.com/uriahf/rtichoke_viz -release=v0.20.0 -source_commit=15e9712686650e23d3c79ddea99892bc5836f5e4 -archive=rtichoke-viz-0.20.0.tar.gz -sha256=9a89356ffa5e72de3526f343960ad21bbc57475a3515748d846cbd447dee17d1 +release=v0.20.1 +source_commit=56e097ab394f3499ef5cfe791e686248df8b39f2 +archive=rtichoke-viz-0.20.1.tar.gz +sha256=17aebfb05a479c3ea28855f6ca3f43cadde7b8b134a2080e309c630c63617629 diff --git a/src/rtichoke/_vendor/rtichoke_viz/rtichoke-viz-0.20.0.tar.gz b/src/rtichoke/_vendor/rtichoke_viz/rtichoke-viz-0.20.0.tar.gz deleted file mode 100644 index ee84f132..00000000 Binary files a/src/rtichoke/_vendor/rtichoke_viz/rtichoke-viz-0.20.0.tar.gz and /dev/null differ diff --git a/src/rtichoke/_vendor/rtichoke_viz/rtichoke-viz-0.20.1.tar.gz b/src/rtichoke/_vendor/rtichoke_viz/rtichoke-viz-0.20.1.tar.gz new file mode 100644 index 00000000..87e56088 Binary files /dev/null and b/src/rtichoke/_vendor/rtichoke_viz/rtichoke-viz-0.20.1.tar.gz differ diff --git a/src/rtichoke/_vendor/rtichoke_viz/rtichoke-viz.css b/src/rtichoke/_vendor/rtichoke_viz/rtichoke-viz.css index 4f36e276..61a45c88 100644 --- a/src/rtichoke/_vendor/rtichoke_viz/rtichoke-viz.css +++ b/src/rtichoke/_vendor/rtichoke_viz/rtichoke-viz.css @@ -191,6 +191,7 @@ border-bottom: 1px solid #f3f4f6; white-space: nowrap; position: relative; + z-index: 0; } .rtichoke-performance-table__table tbody tr:hover { @@ -218,6 +219,11 @@ min-width: 70px; } +.rtichoke-performance-table__cell-text { + position: relative; + z-index: 1; +} + .rtichoke-performance-table__bar { position: absolute; top: 4px; @@ -227,6 +233,7 @@ pointer-events: none; overflow: hidden; border-radius: 2px; + z-index: -1; } .rtichoke-performance-table__bar-fill { @@ -234,20 +241,19 @@ top: 0; bottom: 0; border-radius: 2px; - opacity: 0.25; transition: width 0.2s ease; } .rtichoke-performance-table__bar-fill--positive { - background-color: #2e7559; + background-color: lightgreen; } .rtichoke-performance-table__bar-fill--negative { - background-color: #dc2626; + background-color: pink; } .rtichoke-performance-table__bar-fill--neutral { - background-color: #6b7280; + background-color: lightgrey; } /* Disclosure column & toggle button */ diff --git a/src/rtichoke/_vendor/rtichoke_viz/rtichoke-viz.js b/src/rtichoke/_vendor/rtichoke_viz/rtichoke-viz.js index ccb7d16e..e52b0167 100644 --- a/src/rtichoke/_vendor/rtichoke_viz/rtichoke-viz.js +++ b/src/rtichoke/_vendor/rtichoke_viz/rtichoke-viz.js @@ -20298,7 +20298,10 @@ var PRIMARY_METRIC_ORDER = [ ]; function cell(document2, text2, className) { const element = document2.createElement("td"); - element.textContent = text2; + const contentSpan = document2.createElement("span"); + contentSpan.className = "rtichoke-performance-table__cell-text"; + contentSpan.textContent = text2; + element.append(contentSpan); if (className) element.className = className; return element; } diff --git a/tests/test_rtichoke_viz_vendor.py b/tests/test_rtichoke_viz_vendor.py index 57bf1257..e1b95224 100644 --- a/tests/test_rtichoke_viz_vendor.py +++ b/tests/test_rtichoke_viz_vendor.py @@ -3,19 +3,19 @@ from pathlib import Path _VENDOR = Path(__file__).parents[1] / "src" / "rtichoke" / "_vendor" / "rtichoke_viz" -_RELEASE_DIR = "rtichoke-viz-0.20.0" -_SHA256 = "9a89356ffa5e72de3526f343960ad21bbc57475a3515748d846cbd447dee17d1" -_SOURCE_COMMIT = "15e9712686650e23d3c79ddea99892bc5836f5e4" +_RELEASE_DIR = "rtichoke-viz-0.20.1" +_SHA256 = "17aebfb05a479c3ea28855f6ca3f43cadde7b8b134a2080e309c630c63617629" +_SOURCE_COMMIT = "56e097ab394f3499ef5cfe791e686248df8b39f2" -def test_vendored_rtichoke_viz_v0200_provenance_archive_and_schemas(): +def test_vendored_rtichoke_viz_v0201_provenance_archive_and_schemas(): provenance = (_VENDOR / "VENDORED_FROM").read_text() - assert "release=v0.20.0" in provenance + assert "release=v0.20.1" in provenance assert f"source_commit={_SOURCE_COMMIT}" in provenance - assert "archive=rtichoke-viz-0.20.0.tar.gz" in provenance + assert "archive=rtichoke-viz-0.20.1.tar.gz" in provenance assert f"sha256={_SHA256}" in provenance - archive = _VENDOR / "rtichoke-viz-0.20.0.tar.gz" + archive = _VENDOR / "rtichoke-viz-0.20.1.tar.gz" assert hashlib.sha256(archive.read_bytes()).hexdigest() == _SHA256 with tarfile.open(archive, "r:gz") as release: assert set(release.getnames()) == { @@ -30,7 +30,7 @@ def test_vendored_rtichoke_viz_v0200_provenance_archive_and_schemas(): manifest = release.extractfile(f"{_RELEASE_DIR}/MANIFEST") assert manifest is not None assert manifest.read().decode() == ( - f"version=0.20.0\ncommit={_SOURCE_COMMIT}\n" + f"version=0.20.1\ncommit={_SOURCE_COMMIT}\n" ) for filename in ( "rtichoke-viz.css", @@ -43,6 +43,7 @@ def test_vendored_rtichoke_viz_v0200_provenance_archive_and_schemas(): assert packaged is not None assert (_VENDOR / filename).read_bytes() == packaged.read() + assert not (_VENDOR / "rtichoke-viz-0.20.0.tar.gz").exists() assert not (_VENDOR / "rtichoke-viz-0.19.0.tar.gz").exists() assert not (_VENDOR / "rtichoke-viz-0.14.0.tar.gz").exists() assert (_VENDOR / "rtichoke-viz.js").stat().st_size > 0 @@ -59,7 +60,7 @@ def test_vendored_rtichoke_viz_v0200_provenance_archive_and_schemas(): assert '"summary_metrics"' in report_schema -def test_v0200_bundle_keeps_existing_exports_and_time_dependent_surfaces(): +def test_v0201_bundle_keeps_existing_exports_and_time_dependent_surfaces(): bundle = (_VENDOR / "rtichoke-viz.js").read_text(encoding="utf-8") for export_name in ( "renderRoc",