Skip to content

Vouch request: fix #1384 (MAGIC_LINK_FORCE_HTTP for self-hosted) #3457

@fran-mora

Description

@fran-mora

Why do you want to contribute?

I'm Francesco Moramarco — software engineer in the UK, background in ML/AI infrastructure (most recently building an autonomous scientific discovery platform on LangGraph + Claude Skills + Neo4j).

I'd like to fix #1384, which has been open since October 2024 and has a clear implementation spec from @matt-aitken in the issue thread but no PR has shipped it. The change adds a MAGIC_LINK_FORCE_HTTP env var so self-hosted Trigger.dev instances accessed over a private IP/VPC can keep http magic-link URLs (remix-auth-email-link otherwise upgrades non-localhost hosts to https).

I have the patch ready locally:

  • apps/webapp/app/env.server.ts — adds MAGIC_LINK_FORCE_HTTP: BoolEnv.default(false) next to MAGIC_LINK_SECRET
  • apps/webapp/app/services/email.server.ts — exports a small forceHttpProtocol helper, applied in sendMagicLinkEmail when the env is set
  • apps/webapp/test/email.server.test.ts — vitest cases for the helper (https→http rewrite, http unchanged, path/query/port/fragment preserved, unparseable input passthrough)
  • .server-changes/magic-link-force-http.md — release-notes entry per CONTRIBUTING

Happy to follow the standard workflow (draft PR → CodeRabbit → mark ready) once vouched.

Prior contributions or relevant experience

Recent OSS PRs (both currently pending review):

Stack: TypeScript, Python, Go, Rust, HCL, Bash. I use Claude Code for implementation and review every diff myself before pushing — happy to disclose AI usage on the PR per the project's norms.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions