Skip to content

Commit d860b97

Browse files
committed
Tags query: remove things we’re not using
1 parent f2ea6df commit d860b97

2 files changed

Lines changed: 8 additions & 22 deletions

File tree

apps/webapp/app/presenters/v3/RunTagListPresenter.server.ts

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ export type TagListOptions = {
55
userId?: string;
66
projectId: string;
77
//filters
8-
names?: string[];
9-
environments?: string[];
8+
name?: string;
109
//pagination
1110
page?: number;
1211
pageSize?: number;
@@ -21,31 +20,19 @@ export class RunTagListPresenter extends BasePresenter {
2120
public async call({
2221
userId,
2322
projectId,
24-
names,
25-
environments,
23+
name,
2624
page = 1,
2725
pageSize = DEFAULT_PAGE_SIZE,
2826
}: TagListOptions) {
29-
const hasFilters =
30-
(names !== undefined && names.length > 0) ||
31-
(environments !== undefined && environments.length > 0);
27+
const hasFilters = name;
3228

3329
const tags = await this._replica.taskRunTag.findMany({
3430
where: {
3531
projectId,
36-
OR:
37-
names && names.length > 0
38-
? names.map((name) => ({ name: { contains: name, mode: "insensitive" } }))
39-
: undefined,
40-
project: environments
32+
name: name
4133
? {
42-
environments: {
43-
some: {
44-
id: {
45-
in: environments,
46-
},
47-
},
48-
},
34+
contains: name,
35+
mode: "insensitive",
4936
}
5037
: undefined,
5138
},
@@ -59,8 +46,7 @@ export class RunTagListPresenter extends BasePresenter {
5946
logger.log("tags", {
6047
tags,
6148
projectId,
62-
names,
63-
environments,
49+
name,
6450
});
6551

6652
return {

apps/webapp/app/routes/resources.projects.$projectParam.runs.tags.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export async function loader({ request, params }: LoaderFunctionArgs) {
2626
const presenter = new RunTagListPresenter();
2727
const result = await presenter.call({
2828
projectId: project.id,
29-
names: name ? [decodeURIComponent(name)] : undefined,
29+
name: name ? decodeURIComponent(name) : undefined,
3030
});
3131
return result;
3232
}

0 commit comments

Comments
 (0)