implemented suggested refactor

Author: julienvanbeveren

packages/build/src/extensions/core/syncEnvVars.ts

@@ -155,14 +155,14 @@ async function callSyncEnvVarsFn(
   env: Record<string, string>;
   secrets?: Record<string, boolean>;
   parentEnv?: Record<string, string>;
-  parentEnvSecrets?: Record<string, boolean>;
+  parentSecrets?: Record<string, boolean>;
 } | undefined> {
   if (syncEnvVarsFn && typeof syncEnvVarsFn === "function") {
     let resolvedEnvVars: {
       env: Record<string, string>;
       secrets?: Record<string, boolean>;
       parentEnv?: Record<string, string>;
-      parentEnvSecrets?: Record<string, boolean>;
+      parentSecrets?: Record<string, boolean>;
     } = {
       env: {},
     };
@@ -196,11 +196,11 @@ async function callSyncEnvVarsFn(
           if (item.isParentEnv) {
             if (!resolvedEnvVars.parentEnv) {
               resolvedEnvVars.parentEnv = {};
-              resolvedEnvVars.parentEnvSecrets = {};
+              resolvedEnvVars.parentSecrets = {};
             }
             resolvedEnvVars.parentEnv[item.name] = item.value;
-            if (item.isSecret && resolvedEnvVars.parentEnvSecrets) {
-              resolvedEnvVars.parentEnvSecrets[item.name] = true;
+            if (item.isSecret && resolvedEnvVars.parentSecrets) {
+              resolvedEnvVars.parentSecrets[item.name] = true;
             }
           } else {
             resolvedEnvVars.env[item.name] = item.value;

packages/cli-v3/src/commands/deploy.ts

@@ -606,13 +606,13 @@ export async function syncEnvVarsWithServer(
   envVars: Record<string, string>,
   parentEnvVars?: Record<string, string>,
   secrets?: Record<string, boolean>,
-  parentEnvSecrets?: Record<string, boolean>
+  parentSecrets?: Record<string, boolean>
 ) {
   return await apiClient.importEnvVars(projectRef, environmentSlug, {
     variables: envVars,
     parentVariables: parentEnvVars,
     secrets,
-    parentSecrets: parentEnvSecrets,
+    parentSecrets,
     override: true,
   });
 }