Commit a5bc3ce
committed
chore: address PR review feedback
- runAttemptSystem.ts: remove unreachable `if (packetError)` block.
After `if (!packet) { return; }`, packet is truthy, which means
packetError is null per tryCatch's contract. Pre-existing dead code.
- platform.v3.server.ts: fix stale comment that referenced logger.warn —
the helper only counts a metric (no per-call logging by design).1 parent bdd5a5a commit a5bc3ce
2 files changed
Lines changed: 5 additions & 16 deletions
File tree
- apps/webapp/app/services
- internal-packages/run-engine/src/engine/systems
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
48 | | - | |
49 | | - | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
50 | 51 | | |
51 | 52 | | |
52 | 53 | | |
| |||
Lines changed: 1 addition & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1980 | 1980 | | |
1981 | 1981 | | |
1982 | 1982 | | |
1983 | | - | |
| 1983 | + | |
1984 | 1984 | | |
1985 | 1985 | | |
1986 | 1986 | | |
1987 | 1987 | | |
1988 | 1988 | | |
1989 | | - | |
1990 | | - | |
1991 | | - | |
1992 | | - | |
1993 | | - | |
1994 | | - | |
1995 | | - | |
1996 | | - | |
1997 | | - | |
1998 | | - | |
1999 | | - | |
2000 | | - | |
2001 | 1989 | | |
2002 | 1990 | | |
2003 | 1991 | | |
| |||
0 commit comments