Drop the dirty-state Save tracking from ConfigureErrorAlerts

Revert the formChangeTick / isDirty / stableStringify block — Save is
back to disabled-while-submitting only.

Author: D-K-P

apps/webapp/app/components/errors/ConfigureErrorAlerts.tsx

@@ -9,8 +9,7 @@ import {
 } from "@heroicons/react/20/solid";
 import { useFetcher, useNavigate } from "@remix-run/react";
 import { SlackIcon } from "@trigger.dev/companyicons";
-import { Fragment, useEffect, useMemo, useRef, useState } from "react";
-import stableStringify from "json-stable-stringify";
+import { Fragment, useEffect, useRef, useState } from "react";
 import { z } from "zod";
 import { Button, LinkButton } from "~/components/primitives/Buttons";
 import { Callout, variantClasses } from "~/components/primitives/Callout";
@@ -105,35 +104,6 @@ export function ConfigureErrorAlerts({
     existingWebhooks.length > 0 ? [...existingWebhooks.map((w) => w.url), ""] : [""]
   );
 
-  const [formChangeTick, setFormChangeTick] = useState(0);
-  const bumpFormChange = () => setFormChangeTick((n) => n + 1);
-
-  const isDirty = useMemo(() => {
-    const initialSlackValue = existingSlackChannel
-      ? `${existingSlackChannel.channelId}/${existingSlackChannel.channelName}`
-      : "";
-    if ((selectedSlackChannelValue ?? "") !== initialSlackValue) return true;
-    const currentEmails = emailFieldValues.current.filter((v) => v !== "");
-    if (
-      stableStringify(currentEmails) !==
-      stableStringify(existingEmails.map((e) => e.email))
-    )
-      return true;
-    const currentWebhooks = webhookFieldValues.current.filter((v) => v !== "");
-    if (
-      stableStringify(currentWebhooks) !==
-      stableStringify(existingWebhooks.map((w) => w.url))
-    )
-      return true;
-    return false;
-  }, [
-    selectedSlackChannelValue,
-    existingSlackChannel,
-    existingEmails,
-    existingWebhooks,
-    formChangeTick,
-  ]);
-
   const [form, { emails, webhooks, slackChannel, slackIntegrationId }] = useForm({
     id: "configure-error-alerts",
     onValidate({ formData }) {
@@ -195,7 +165,6 @@ export function ConfigureErrorAlerts({
                         icon={EnvelopeIcon}
                         onChange={(e) => {
                           emailFieldValues.current[index] = e.target.value;
-                          bumpFormChange();
                           if (
                             emailFields.length === emailFieldValues.current.length &&
                             emailFieldValues.current.every((v) => v !== "")
@@ -358,7 +327,6 @@ export function ConfigureErrorAlerts({
                       icon={GlobeAltIcon}
                       onChange={(e) => {
                         webhookFieldValues.current[index] = e.target.value;
-                        bumpFormChange();
                         if (
                           webhookFields.length === webhookFieldValues.current.length &&
                           webhookFieldValues.current.every((v) => v !== "")
@@ -385,7 +353,7 @@ export function ConfigureErrorAlerts({
           <Button
             variant="primary/medium"
             type="submit"
-            disabled={!isDirty || isSubmitting}
+            disabled={isSubmitting}
             isLoading={isSubmitting}
           >
             {isSubmitting ? "Saving…" : "Save"}