RBAC tests: extract projectCreated to break platform.v3.server cycle (TRI-8731)

After rebasing rbac-packages on origin/main, the e2e.full harness
regressed with the same `TypeError: Cannot convert undefined or null
to object at allMachines (build/index.js:71862)` that TRI-8731
worked around by switching the testcontainer to NODE_ENV=production.
Recent main commits changed the bundled init order enough that the
production-mode dodge no longer applies — the cycle now triggers in
both NODE_ENV=test and NODE_ENV=production.

Root cause is structural:

  app/services/platform.v3.server  →  imports createEnvironment
                                      from app/models/organization.server
  app/models/organization.server   →  imports getDefaultEnvironmentConcurrencyLimit
                                      from app/services/platform.v3.server

Inside an esbuild __esm bundle, this manifests as:

  init_platform_v3_server() runs init_organization_server() in the
  middle of its body. organization.server's body re-enters
  init_platform_v3_server(), which short-circuits because the outer
  call already cleared its `fn` — so `({ defaultMachine, machines } =
  singleton("machinePresets", ...))` never completes its destructure
  and both vars stay undefined. Object.entries(undefined) crashes
  when `allMachines()` runs inside `createRunEngine()`.

Fix: move the only function in platform.v3.server.ts that imports
from organization.server (`projectCreated`, the sole caller of
`createEnvironment`) into its own file. platform.v3.server.ts no
longer imports from organization.server, so the cycle is gone. Two
trivial supporting changes:

  - export `isCloud` from platform.v3.server (projectCreated needs it)
  - drop the now-unused `Organization` and `Project` type imports

No dynamic imports, no application-code workarounds — just a
structural file split.

Verified:
  - 162/162 e2e.full pass (auth-api, auth-cross-cutting, auth-dashboard)
  - 31/31 api-auth.e2e pass
  - 31/31 @trigger.dev/rbac unit tests pass
  - 7/7 cloud enterprise e2e.full pass against the same webapp build

Author: matt-aitken

apps/webapp/app/models/project.server.ts

@@ -4,7 +4,7 @@ import { $replica, prisma } from "~/db.server";
 import type { Prisma, Project } from "@trigger.dev/database";
 import { type Organization, createEnvironment } from "./organization.server";
 import { env } from "~/env.server";
-import { projectCreated } from "~/services/platform.v3.server";
+import { projectCreated } from "~/services/projectCreated.server";
 export type { Project } from "@trigger.dev/database";
 
 const externalRefGenerator = customAlphabet("abcdefghijklmnopqrstuvwxyz", 20);

apps/webapp/app/services/platform.v3.server.ts

@@ -1,5 +1,5 @@
 import { MachinePresetName, tryCatch } from "@trigger.dev/core/v3";
-import type { Organization, Project, RuntimeEnvironmentType } from "@trigger.dev/database";
+import type { RuntimeEnvironmentType } from "@trigger.dev/database";
 import {
   BillingClient,
   defaultMachine as defaultMachineFromPlatform,
@@ -25,7 +25,6 @@ import { redirect } from "remix-typedjson";
 import { z } from "zod";
 import { env } from "~/env.server";
 import { redirectWithErrorMessage, redirectWithSuccessMessage } from "~/models/message.server";
-import { createEnvironment } from "~/models/organization.server";
 import { logger } from "~/services/logger.server";
 import { newProjectPath, organizationBillingPath } from "~/utils/pathBuilder";
 import { singleton } from "~/utils/singleton";
@@ -569,33 +568,6 @@ export async function getEntitlement(
   return result.val;
 }
 
-export async function projectCreated(
-  organization: Pick<Organization, "id" | "maximumConcurrencyLimit">,
-  project: Project
-) {
-  if (!isCloud()) {
-    await createEnvironment({ organization, project, type: "STAGING" });
-    await createEnvironment({
-      organization,
-      project,
-      type: "PREVIEW",
-      isBranchableEnvironment: true,
-    });
-  } else {
-    //staging is only available on certain plans
-    const plan = await getCurrentPlan(organization.id);
-    if (plan?.v3Subscription.plan?.limits.hasStagingEnvironment) {
-      await createEnvironment({ organization, project, type: "STAGING" });
-      await createEnvironment({
-        organization,
-        project,
-        type: "PREVIEW",
-        isBranchableEnvironment: true,
-      });
-    }
-  }
-}
-
 export async function getBillingAlerts(
   organizationId: string
 ): Promise<BillingAlertsResult | undefined> {
@@ -770,7 +742,7 @@ export async function triggerInitialDeployment(
   }
 }
 
-function isCloud(): boolean {
+export function isCloud(): boolean {
   const acceptableHosts = [
     "https://cloud.trigger.dev",
     "https://test-cloud.trigger.dev",

apps/webapp/app/services/projectCreated.server.ts

@@ -0,0 +1,35 @@
+import type { Organization, Project } from "@trigger.dev/database";
+import { createEnvironment } from "~/models/organization.server";
+import { getCurrentPlan, isCloud } from "~/services/platform.v3.server";
+
+// Extracted from platform.v3.server.ts to break a circular import:
+// platform.v3.server ↔ models/organization.server (via createEnvironment).
+// The cycle caused the bundled __esm wrappers to re-enter and short-circuit
+// the platform.v3.server init, leaving `defaultMachine` and `machines`
+// undefined in `singleton("machinePresets", ...)` — the boot crash at
+// `allMachines()` traced to TRI-8731.
+export async function projectCreated(
+  organization: Pick<Organization, "id" | "maximumConcurrencyLimit">,
+  project: Project
+) {
+  if (!isCloud()) {
+    await createEnvironment({ organization, project, type: "STAGING" });
+    await createEnvironment({
+      organization,
+      project,
+      type: "PREVIEW",
+      isBranchableEnvironment: true,
+    });
+  } else {
+    const plan = await getCurrentPlan(organization.id);
+    if (plan?.v3Subscription.plan?.limits.hasStagingEnvironment) {
+      await createEnvironment({ organization, project, type: "STAGING" });
+      await createEnvironment({
+        organization,
+        project,
+        type: "PREVIEW",
+        isBranchableEnvironment: true,
+      });
+    }
+  }
+}