fix stuck deploy command after finalize error

Author: nicktrn

packages/cli-v3/src/apiClient.ts

@@ -289,11 +289,9 @@ export class CliApiClient {
     }
 
     let resolvePromise: (value: ApiResult<FailDeploymentResponseBody>) => void;
-    let rejectPromise: (reason: any) => void;
 
-    const promise = new Promise<ApiResult<FailDeploymentResponseBody>>((resolve, reject) => {
+    const promise = new Promise<ApiResult<FailDeploymentResponseBody>>((resolve) => {
       resolvePromise = resolve;
-      rejectPromise = reject;
     });
 
     const source = zodfetchSSE({
@@ -311,9 +309,15 @@ export class CliApiClient {
     });
 
     source.onConnectionError((error) => {
-      rejectPromise({
+      let message = error.message ?? "Unknown error";
+
+      if (error.status !== undefined) {
+        message = `HTTP ${error.status} ${message}`;
+      }
+
+      resolvePromise({
         success: false,
-        error,
+        error: message,
       });
     });
 
@@ -325,7 +329,7 @@ export class CliApiClient {
     });
 
     source.onMessage("error", ({ error }) => {
-      rejectPromise({
+      resolvePromise({
         success: false,
         error,
       });

packages/core/src/v3/apiClient/core.ts

@@ -17,7 +17,7 @@ import {
   OffsetLimitPageParams,
   OffsetLimitPageResponse,
 } from "./pagination.js";
-import { EventSource } from "eventsource";
+import { EventSource, type ErrorEvent } from "eventsource";
 
 export const defaultRetryOptions = {
   maxAttempts: 3,
@@ -665,7 +665,7 @@ export class ZodFetchSSEResult<TMessageCatalog extends ZodFetchSSEMessageCatalog
     });
   }
 
-  public onConnectionError(handler: (error: Event) => void) {
+  public onConnectionError(handler: (error: ErrorEvent) => void) {
     this._eventSource.onerror = handler;
   }