Skip to content

Commit 5f9fe37

Browse files
committed
feat(webapp): clarify cross-region intent in private connections helpers
1 parent af26905 commit 5f9fe37

2 files changed

Lines changed: 11 additions & 2 deletions

File tree

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
area: webapp
3+
type: improvement
4+
---
5+
6+
Clarify the cross-region intent in the Terraform and AI-prompt helpers on the Add Private Connection page. Both already default `supported_regions` to `["us-east-1", "eu-central-1"]`; added an inline comment / parenthetical so the user understands why both regions are listed (Trigger.dev runs in both, so the service must be consumable from either).

apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.private-connections.new/route.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,10 @@ resource "aws_lb_listener" "port_${p.port}" {
270270
resource "aws_vpc_endpoint_service" "trigger_privatelink" {
271271
acceptance_required = false
272272
network_load_balancer_arns = [aws_lb.trigger_privatelink.arn]
273-
supported_regions = ["us-east-1", "eu-central-1"]
273+
274+
# Trigger.dev runs in us-east-1 and eu-central-1. Listing both makes this
275+
# service consumable from either region so any of your tasks can connect.
276+
supported_regions = ["us-east-1", "eu-central-1"]
274277
275278
allowed_principals = [
276279
${awsAccountIds.map((id) => ` "arn:aws:iam::${id}:root",`).join("\n")}
@@ -422,7 +425,7 @@ ${validPorts.length > 0 ? validPorts.map((p) => ` - Port ${p.port} (${p.protoc
422425
3. A VPC Endpoint Service:
423426
- Acceptance required: no
424427
- Attach the NLB created above
425-
- Supported regions: us-east-1, eu-central-1
428+
- Supported regions: us-east-1, eu-central-1 (these are the AWS regions Trigger.dev runs in, so the service must be consumable from both)
426429
- Allowed principals:
427430
${awsAccountIds.map((id) => ` - arn:aws:iam::${id}:root`).join("\n") || " - <Trigger.dev AWS account ARN>"}
428431

0 commit comments

Comments
 (0)