prevent overly friendly ids

nicktrn · nicktrn · commit 25c1042ae93b · 2025-03-20T09:50:23.000Z
diff --git a/packages/core/src/v3/isomorphic/friendlyId.ts b/packages/core/src/v3/isomorphic/friendlyId.ts
@@ -21,6 +21,10 @@ export function toFriendlyId(entityName: string, internalId: string): string {
     throw new Error("Internal ID cannot be empty");
   }
 
+  if (internalId.startsWith(`${entityName}_`)) {
+    return internalId;
+  }
+
   return `${entityName}_${internalId}`;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,10 @@ export function toFriendlyId(entityName: string, internalId: string): string {`
`21`	`21`	`throw new Error("Internal ID cannot be empty");`
`22`	`22`	`}`
`23`	`23`
	`24`	+ if (internalId.startsWith(`${entityName}_`)) {
	`25`	`+ return internalId;`
	`26`	`+ }`
	`27`	`+`
`24`	`28`	return `${entityName}_${internalId}`;
`25`	`29`	`}`
`26`	`30`