Skip to content

Commit 2464ddf

Browse files
committed
ci: scope permissions per-job + suppress vouch dangerous-triggers
1 parent d9497f4 commit 2464ddf

4 files changed

Lines changed: 25 additions & 8 deletions

File tree

.github/workflows/pr_checks.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ concurrency:
1515

1616
permissions:
1717
contents: read
18-
id-token: write
1918

2019
jobs:
2120
typecheck:

.github/workflows/publish.yml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@ on:
3737
- "tests/**"
3838

3939
permissions:
40-
id-token: write
41-
packages: write
4240
contents: read
4341

4442
concurrency:
@@ -58,20 +56,31 @@ jobs:
5856

5957
publish-webapp:
6058
needs: [typecheck]
59+
permissions:
60+
contents: read
61+
packages: write
62+
id-token: write
6163
uses: ./.github/workflows/publish-webapp.yml
6264
secrets: inherit
6365
with:
6466
image_tag: ${{ inputs.image_tag }}
6567

6668
publish-worker:
6769
needs: [typecheck]
70+
permissions:
71+
contents: read
72+
packages: write
6873
uses: ./.github/workflows/publish-worker.yml
6974
secrets: inherit
7075
with:
7176
image_tag: ${{ inputs.image_tag }}
7277

7378
publish-worker-v4:
7479
needs: [typecheck]
80+
permissions:
81+
contents: read
82+
packages: write
83+
id-token: write
7584
uses: ./.github/workflows/publish-worker-v4.yml
7685
secrets: inherit
7786
with:

.github/workflows/release.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ jobs:
3333
show-release-summary:
3434
name: 📋 Release Summary
3535
runs-on: ubuntu-latest
36+
permissions: {}
3637
if: |
3738
github.repository == 'triggerdotdev/trigger.dev' &&
3839
github.event_name == 'pull_request' &&
@@ -164,6 +165,10 @@ jobs:
164165
name: 🐳 Publish Docker images
165166
needs: release
166167
if: needs.release.outputs.published == 'true'
168+
permissions:
169+
contents: read
170+
packages: write
171+
id-token: write
167172
uses: ./.github/workflows/publish.yml
168173
secrets: inherit
169174
with:
@@ -233,6 +238,7 @@ jobs:
233238
needs: [release, update-release]
234239
if: needs.release.outputs.published == 'true'
235240
runs-on: ubuntu-latest
241+
permissions: {}
236242
steps:
237243
- uses: peter-evans/repository-dispatch@28959ce8df70de7be546dd1250a005dd32156697 # v4.0.1
238244
with:

.github/workflows/vouch-check-pr.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
11
name: Vouch - Check PR
22

33
on:
4-
pull_request_target:
4+
pull_request_target: # zizmor: ignore[dangerous-triggers] vouch needs to comment on fork PRs
55
types: [opened, reopened]
66

7-
permissions:
8-
contents: read
9-
pull-requests: write
10-
issues: read
7+
permissions: {}
118

129
jobs:
1310
check-vouch:
1411
runs-on: ubuntu-latest
12+
permissions:
13+
contents: read
14+
pull-requests: write # auto-close unvouched PRs
15+
issues: read
1516
steps:
1617
- uses: mitchellh/vouch/action/check-pr@c6d80ead49839655b61b422700b7a3bc9d0804a9 # v1.4.2
1718
with:
@@ -23,6 +24,8 @@ jobs:
2324

2425
require-draft:
2526
needs: check-vouch
27+
permissions:
28+
pull-requests: write # close non-draft PRs with a comment
2629
if: >
2730
github.event.pull_request.draft == false &&
2831
github.event.pull_request.author_association != 'MEMBER' &&

0 commit comments

Comments
 (0)