Skip to content

Commit 1dfd595

Browse files
authored
fix(webapp): invalid HTML nesting in errors Activity tooltip (#3488)
The Activity peak count tooltip in the errors list rendered a `<button>` (from `SimpleTooltip`'s default `TooltipTrigger`) inside the row's `<a>` link (`TableCell to={errorPath}`). Interactive content nested inside other interactive content is invalid HTML and triggers accessibility warnings. Adding `asChild` to `SimpleTooltip` makes the existing `<span>` the trigger directly, removing the nested `<button>`.
1 parent e2b9e0f commit 1dfd595

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.errors._index

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.errors._index/route.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -708,6 +708,7 @@ function ErrorActivityGraph({ activity }: { activity: ErrorOccurrenceActivity })
708708
</ResponsiveContainer>
709709
</div>
710710
<SimpleTooltip
711+
asChild
711712
button={
712713
<span className="-mt-1 text-xxs tabular-nums text-text-dimmed">
713714
{formatNumberCompact(maxCount)}

0 commit comments

Comments
 (0)