refactor(webapp): match template results to presets by (cpu, memory_gb) content

Author: nicktrn

apps/webapp/app/v3/services/computeTemplateCreation.server.ts

@@ -230,10 +230,10 @@ export class ComputeTemplateCreationService {
   // or the request itself failed. Optional preset failures are logged and
   // do not contribute to the message. Returns undefined on success.
   //
-  // Result-to-preset matching is by index: response.results[i] corresponds
-  // to this.presets[i]. While the multi-config compute path is being built
-  // out, the gateway may return fewer entries than presets requested - any
-  // unbuilt required preset is still treated as a failure.
+  // Result-to-preset matching is by (cpu, memory_gb) content. Compute may
+  // return fewer entries than presets requested (multi-config path being
+  // built out, or dedup of equivalent configs) - any unbuilt required preset
+  // is still treated as a failure.
   private failureMessageForRequiredMode(
     outcome: CreateTemplateOutcome,
     deploymentFriendlyId: string,
@@ -245,9 +245,13 @@ export class ComputeTemplateCreationService {
 
     const failures: string[] = [];
 
-    this.presets.forEach((preset, i) => {
+    this.presets.forEach((preset) => {
       const isRequired = this.requiredPresets.has(preset.name);
-      const result = outcome.results[i];
+      const result = outcome.results.find(
+        (r) =>
+          Math.abs(r.machine_config.cpu - preset.cpu) < 1e-9 &&
+          Math.abs(r.machine_config.memory_gb - preset.memory_gb) < 1e-9
+      );
 
       if (!result) {
         if (isRequired) {