Commit a665371
committed
test(tools): Use bracket=False + trailing newline in test_paste_text for CI reliability
why: CI on tmux 3.6 kept failing the marker-in-capture assertion
even with a 10-second retry window. Local probing showed the paste
was delivered in ~0.1s, so the CI timeout was a symptom, not the
cause. The real fragility is bracket=True: tmux wraps the paste in
ESC[200~...ESC[201~ bracket markers, and bash readline needs a
prompt cycle to latch bracketed-paste mode. On CI, if paste_text
runs before that latch, the escape sequences get consumed as
unrecognized input and the marker never reaches the visible pane
buffer at all — no amount of retrying would recover it.
what:
- Set bracket=False explicitly in test_paste_text, sending raw
bytes that don't depend on readline state.
- Append a trailing newline to the text so the shell executes the
echo command instead of just queuing input. This exercises the
full paste->execute->output round-trip.
- Expand the comment to document the bracket-mode rationale so
future editors don't flip it back to the default.
The paste_text tool itself still defaults to bracket=True, which
is the right default for multi-line paste into a ready shell.
Only the test needed to trade that off against CI determinism.
The no-leak sibling test (test_paste_text_does_not_leak_named_buffer)
independently verifies the buffer-isolation claim and is unaffected
by this change.1 parent f0d69b6 commit a665371
1 file changed
Lines changed: 17 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
957 | 957 | | |
958 | 958 | | |
959 | 959 | | |
960 | | - | |
| 960 | + | |
| 961 | + | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
| 969 | + | |
| 970 | + | |
| 971 | + | |
961 | 972 | | |
962 | | - | |
| 973 | + | |
963 | 974 | | |
| 975 | + | |
964 | 976 | | |
965 | 977 | | |
966 | 978 | | |
967 | 979 | | |
968 | | - | |
969 | | - | |
970 | | - | |
971 | | - | |
972 | | - | |
973 | | - | |
| 980 | + | |
| 981 | + | |
| 982 | + | |
974 | 983 | | |
975 | 984 | | |
976 | 985 | | |
| |||
0 commit comments