HR Performance reviews: Overall rating, needed?

[pakricard]

Hi @timschofield:

If the status of a review is still draft, we should have an overall rating of “Pending” available, as the reviewer still can't do the review, as the first step is to create the draft.

So,

1. should we add "Pending" here?

2. Or should it be calculated by webERP and NOT the user? Why? Because the review is lated "rated" in HRPerformanceRatings.php, where the reviewer really inputs the valuation of the job done (1 to 5) following the criteria selected (see HR Performance Reviews, Positions, Scales and Criteria Relationships. Something missing? #923 regarding which criteria to show). After "Save", webERP calculates the current overall score, and from there it can be stored as review overall rating.

Screenshot from HRPerformanceRatings.php:

I think we should go for option 2)

R

[timschofield]

@pakricard I have uploaded the start of a fix for this. Can you check if there is anything I have missed/misunderstood

Notes

Should we make the OverallRating select read-only / removed or clearly document that the system will overwrite it when the reviewer saves ratings?
Existing reviews with saved criterion ratings will be updated when a reviewer saves ratings (the save now writes the mapped label). Should we have a Z_ script to recalculate for all currently existing reviews,?

[pakricard]

Thanks @timschofield :
I think the main issue to fix is conceptual, and discussed in #923. Once we have this defined, we can easily figure this #925

But as I see it, in HRPerformanceReviews.php, when the "status" is draft, the overall rating should be "Pending", because being a draft, it means "work in progress" and the reviewer still doesn't know if the employee review will be satisfactory, unsatisfactory, outstanding, etc.

Other issue: The rating scale: I think here it has no use: It should be "position criteria" as I proposed in #923

Other issue. When clicking Edit of an existing review dates are lost, even they are properly stored in the DB. script does not read them to allow the edit)

Regarding HRPerformanceRatings.php:

The script selects ALL criteria, but it should select only the criteria relevant to the position of the employee being evaluated

[pakricard]

Another thing that seems confisung to me (or version mess):

1. In HRAppraisalEntry, the criteria is shown and evaluated against the rating ("outstanding, meets expectations, unsatisfactory, etc)

2. In HRPerformanceRatings the criteria is shown and evaluated against the 1-5 scale

So, it is not clear which is the correct one, which is the proper workflow to get an employee properly evaluated

[pakricard]

@timschofield : Do you have any document describing the workflow on employee evaluations? Maybe, if we start by the "what" and "when", will be easier to sort out the "how to" ;-)

Could we start by defining the "core basics" of the HRD and later keep upgrading the system? As example: Should we start by making performance reviews (or performance appraisals) workable?

R