From 881b8a8825715ed2bf2dffa1bb2efd819eeb3339 Mon Sep 17 00:00:00 2001 From: Viacheslav Klimov Date: Tue, 4 Nov 2025 12:47:19 +0200 Subject: [PATCH 1/2] Refactoring for data_converters_validator.py --- data_converters_validator.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/data_converters_validator.py b/data_converters_validator.py index 88e8ab66..506eeee9 100644 --- a/data_converters_validator.py +++ b/data_converters_validator.py @@ -147,7 +147,13 @@ def validate_uplink_downlink(directory): raise ValueError(f"Directory '{directory}' is not recognized as 'uplink' or 'downlink'.") result_value = actual_result.get() - output = result_value.get('outputMsg') if is_dedicated else json.loads(result_value.get('output')) + if is_dedicated: + output = result_value.get('outputMsg') + else: + output = result_value.get('output') + if not output: + raise ValueError(f"No 'output' field for converter from {directory} with payload {payload_file}.") + output = json.loads(output) error = result_value.get('error') if error != '': From 3b85e70655da44c33cd8fc6b2f1801023109e62f Mon Sep 17 00:00:00 2001 From: Artem Barysh Date: Wed, 5 Nov 2025 11:24:49 +0200 Subject: [PATCH 2/2] Log test --- data_converters_validator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data_converters_validator.py b/data_converters_validator.py index 506eeee9..89d4f353 100644 --- a/data_converters_validator.py +++ b/data_converters_validator.py @@ -152,7 +152,7 @@ def validate_uplink_downlink(directory): else: output = result_value.get('output') if not output: - raise ValueError(f"No 'output' field for converter from {directory} with payload {payload_file}.") + raise ValueError(f"No 'output' field for converter from {directory} with payload {payload_file} and result {result_value}.") output = json.loads(output) error = result_value.get('error')